Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored data sources service for improved structure and asynchronicity #337

Conversation

vsun757
Copy link

@vsun757 vsun757 commented Jan 9, 2024

No description provided.

@vsun757 vsun757 requested a review from ElJocko January 9, 2024 23:47
@vsun757 vsun757 changed the title 301 refactor data sources service for improved structure and asynchronicity Refactored data sources service for improved structure and asynchronicity Jan 9, 2024
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 205 lines in your changes are missing coverage. Please review.

Comparison is base (434003f) 68.25% compared to head (1125eab) 68.24%.
Report is 66 commits behind head on project-orion.

Files Patch % Lines
app/services/data-sources-service.js 52.21% 54 Missing ⚠️
app/controllers/techniques-controller.js 59.34% 37 Missing ⚠️
app/controllers/data-sources-controller.js 63.41% 30 Missing ⚠️
app/controllers/campaigns-controller.js 64.55% 28 Missing ⚠️
app/repository/references-repository.js 81.98% 20 Missing ⚠️
app/repository/user-accounts-repository.js 0.00% 14 Missing ⚠️
app/services/techniques-service.js 85.18% 8 Missing ⚠️
app/repository/_base.repository.js 64.70% 6 Missing ⚠️
app/services/references-service.js 84.00% 4 Missing ⚠️
app/services/collection-bundles-service.js 83.33% 3 Missing ⚠️
... and 1 more
Additional details and impacted files
@@                Coverage Diff                @@
##           project-orion     #337      +/-   ##
=================================================
- Coverage          68.25%   68.24%   -0.01%     
=================================================
  Files                145      146       +1     
  Lines              15997    15737     -260     
  Branches            1936     1887      -49     
=================================================
- Hits               10918    10740     -178     
+ Misses              5071     4989      -82     
  Partials               8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Jack Sheriff added 2 commits January 12, 2024 11:44
…or-improved-structure-and-asynchronicity

# Conflicts:
#	app/services/data-sources-service.js
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

7.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@ElJocko ElJocko merged commit 00f34ce into project-orion Jan 12, 2024
2 of 4 checks passed
@ElJocko ElJocko deleted the 301-refactor-data-sources-service-for-improved-structure-and-asynchronicity branch January 12, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants