-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored data sources service for improved structure and asynchronicity #337
Merged
ElJocko
merged 12 commits into
project-orion
from
301-refactor-data-sources-service-for-improved-structure-and-asynchronicity
Jan 12, 2024
Merged
Refactored data sources service for improved structure and asynchronicity #337
ElJocko
merged 12 commits into
project-orion
from
301-refactor-data-sources-service-for-improved-structure-and-asynchronicity
Jan 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or-improved-structure-and-asynchronicity
…or-improved-structure-and-asynchronicity
vsun757
changed the title
301 refactor data sources service for improved structure and asynchronicity
Refactored data sources service for improved structure and asynchronicity
Jan 9, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## project-orion #337 +/- ##
=================================================
- Coverage 68.25% 68.24% -0.01%
=================================================
Files 145 146 +1
Lines 15997 15737 -260
Branches 1936 1887 -49
=================================================
- Hits 10918 10740 -178
+ Misses 5071 4989 -82
Partials 8 8 ☔ View full report in Codecov by Sentry. |
…or-improved-structure-and-asynchronicity # Conflicts: # app/services/data-sources-service.js
Quality Gate failedFailed conditions 7.0% Duplication on New Code (required ≤ 3%) |
ElJocko
deleted the
301-refactor-data-sources-service-for-improved-structure-and-asynchronicity
branch
January 12, 2024 16:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.