Refactored marking definitions service

[vsun757]

No description provided.

[codecov]

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (ab23273) 68.40% compared to head (dafc60b) 68.28%.
Report is 1 commits behind head on project-orion.

❗ Current head dafc60b differs from pull request most recent head 404efbd. Consider uploading reports for the commit 404efbd to get more accurate results

Files	Patch %	Lines
app/controllers/marking-definitions-controller.js	66.66%	17 Missing and 1 partial ⚠️
app/services/marking-definitions-service.js	76.38%	17 Missing ⚠️

Additional details and impacted files

@@                Coverage Diff                @@
##           project-orion     #336      +/-   ##
=================================================
- Coverage          68.40%   68.28%   -0.12%     
=================================================
  Files                146      147       +1     
  Lines              15488    16341     +853     
  Branches            1837     2000     +163     
=================================================
+ Hits               10595    11159     +564     
- Misses              4885     5173     +288     
- Partials               8        9       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate failed

Failed conditions

5.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud