Making data components service merge ready #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of string literal
…of instantiation rather than in constructor
… point of instantiation rather than in constructor
…per to ensure InvalidTypeError thrown when data.stix.type is not intrusion-set
…instead of retrieveOneById
…ervice.retrieveVersionById because it appears to be unused/useless
…ke debugging tests easier
…ting via global module import
…ype validation check to 'create' method
…o service.create in the importBundle function within collection-bundles.service
…efactor-groups-service Refactored groups service
Modify techniques service to work with async tactics service function.
…efactor-tactics-service Refactor tactics service
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 302-refactor-data-components-service-for-improved-structure-and-asynchronicity #334 +/- ##
=================================================================================================================
Coverage ? 67.71%
=================================================================================================================
Files ? 144
Lines ? 16822
Branches ? 2072
=================================================================================================================
Hits ? 11391
Misses ? 5424
Partials ? 7 ☔ View full report in Codecov by Sentry. |
vsun757
merged commit b347d4c
into
302-refactor-data-components-service-for-improved-structure-and-asynchronicity
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.