332 resolve discrepencies on project branch #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…correct retrieveOne method to search by 'id' instead of 'stix.id'
…itory to more accurately reflect the importation of an object/class instance as opposed to a class
…ongoose query with repository's retrieveOneByVersion method for better abstraction
…sRepository to more accurately reflect the importation of an object/class instance as opposed to a class
…uery for improved query execution
…owercase referencesRepository to more accurately reflect the importation of an object/class instance as opposed to a class; Add repository argument to ReferencesService constructor and set this.repository accordingly
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## project-orion #333 +/- ##
==============================================
Coverage 68.03% 68.03%
==============================================
Files 146 144 -2
Lines 16441 16430 -11
Branches 2013 2009 -4
==============================================
- Hits 11185 11178 -7
+ Misses 5248 5244 -4
Partials 8 8 ☔ View full report in Codecov by Sentry. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #332
CollectionBundlesRepository).exec()is chained on all Mongoose queriescamelCaseobjects (rather thanPascalCase) to better reflect the importation of singelton objects as opposed to classes