294 refactor references service #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## project-orion #331 +/- ##
=================================================
+ Coverage 67.68% 67.83% +0.15%
=================================================
Files 144 145 +1
Lines 16788 16799 +11
Branches 2068 2075 +7
=================================================
+ Hits 11363 11396 +33
+ Misses 5417 5395 -22
Partials 8 8 ☔ View full report in Codecov by Sentry. |
Cleaned up some formatting. Moved pagination back to repository service (and used base service pagination function). Modified error handling to match base service and base repository.
|
ElJocko
approved these changes
Dec 20, 2023
|
Closes #294 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.