Refactored recent activity service for improved structure and asynchronicity #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## project-orion #320 +/- ##
=================================================
+ Coverage 67.68% 73.05% +5.36%
=================================================
Files 138 154 +16
Lines 17692 18446 +754
Branches 2233 3043 +810
=================================================
+ Hits 11975 13475 +1500
+ Misses 5710 4964 -746
Partials 7 7 ☔ View full report in Codecov by Sentry. |
|
|
…e-for-improved-structure-and-asynchronicity
* Add new relationships-repository module * Refactor functional to OOP * Refactor callbacks to promises
Resolved the following linting errors: * Error: 6:9 error 'BadlyFormattedParameterError' is assigned a value but never used no-unused-vars * Error: 6:54 error 'DuplicateIdError' is assigned a value but never used no-unused-vars * Error: 26:5 error Expected 'this' to be used by class method '_buildQuery' class-methods-use-this * Error: 55:5 error Expected 'this' to be used by class method '_buildAggregation' class-methods-use-this * Error: 71:5 error Expected 'this' to be used by class method '_addLookupStages' class-methods-use-this * Error: 92:5 error Expected 'this' to be used by class method '_applyFilters' class-methods-use-this
Resolved the following linting errors in pagination-async.js: * Error: 27:5 error Expected blank line between class members lines-between-class-members * Error: 45:5 error Expected blank line between class members lines-between-class-members * Error: 144:35 error Unexpected parentheses around single function argument arrow-parens
seansica
deleted the
295-refactor-recent-activity-service-for-improved-structure-and-asynchronicity
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.