Fix lastUpdatedBy query to retrieve recent relationship activity for …

…more than one user (#273)

* update gitignore

* update formatting

* fix bug in lastUpdatedBy query

.gitignore

@@ -147,3 +147,4 @@ Temporary Items
 
 # Directory holding files that are for local use only
 /local-only
+/certs

app/lib/request-parameter-helper.js

@@ -1,11 +1,11 @@
 const lastUpdatedByQueryHelper = function (lastUpdatedByOption) {
-  if (Array.isArray(lastUpdatedByOption)) {
-    return { $in: lastUpdatedByOption };
-  } else {
-      return lastUpdatedByOption;
-  }
+	if (Array.isArray(lastUpdatedByOption)) {
+		return { $in: lastUpdatedByOption };
+	} else {
+		return lastUpdatedByOption;
+	}
 };
 
 module.exports = {
-  lastUpdatedByQueryHelper,
+	lastUpdatedByQueryHelper,
 };

app/services/attack-objects-service.js

@@ -6,7 +6,8 @@ const AttackObject = require('../models/attack-object-model');
 const Relationship = require('../models/relationship-model');
 const identitiesService = require('./identities-service');
 const systemConfigurationService = require('./system-configuration-service');
-const {lastUpdatedByQueryHelper} = require('../lib/request-parameter-helper');
+
+const { lastUpdatedByQueryHelper } = require('../lib/request-parameter-helper');
 
 const regexValidator = require('../lib/regex');
 
@@ -52,7 +53,7 @@ exports.retrieveAll = async function(options) {
     }
 
     if (typeof options.lastUpdatedBy !== 'undefined') {
-      query['workspace.workflow.created_by_user_account'] = lastUpdatedByQueryHelper(options.lastUpdatedBy);
+        query['workspace.workflow.created_by_user_account'] = lastUpdatedByQueryHelper(options.lastUpdatedBy);
     }
 
     // Build the aggregation

app/services/relationships-service.js

@@ -7,6 +7,8 @@ const identitiesService = require('./identities-service');
 const attackObjectsService = require('./attack-objects-service');
 const config = require('../config/config');
 
+const { lastUpdatedByQueryHelper } = require('../lib/request-parameter-helper');
+
 const errors = {
     missingParameter: 'Missing required parameter',
     badlyFormattedParameter: 'Badly formatted parameter',
@@ -58,12 +60,7 @@ exports.retrieveAll = async function(options) {
         query['stix.relationship_type'] = options.relationshipType;
     }
     if (typeof options.lastUpdatedBy !== 'undefined') {
-        if (Array.isArray(options.attackId)) {
-            query['workspace.workflow.created_by_user_account'] = { $in: options.lastUpdatedBy };
-        }
-        else {
-            query['workspace.workflow.created_by_user_account'] = options.lastUpdatedBy;
-        }
+        query['workspace.workflow.created_by_user_account'] = lastUpdatedByQueryHelper(options.lastUpdatedBy);
     }
 
     // Build the aggregation