same as last

center-for-threat-informed-defense · May 17, 2023 · 5a72a1a · 5a72a1a
1 parent 827f993
commit 5a72a1a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/app/controllers/matrices-controller.js b/app/controllers/matrices-controller.js
@@ -170,8 +170,8 @@ exports.deleteById = function(req, res) {
 };
 
 
-exports.retrieveVersionTechniquesById = function(req, res) {
-    matricesService.retrieveVersionTechniquesById(req.params.stixId, req.params.modified, function (err, matrix) {
+exports.retrieveVersionTechniquesById = async function(req, res) {
+    await matricesService.retrieveVersionTechniquesById(req.params.stixId, req.params.modified, function (err, matrix) {
         if (err) {
             if (err.message === matricesService.errors.badlyFormattedParameter) {
                 logger.warn('Badly formatted stix id: ' + req.params.stixId);

diff --git a/app/services/matrices-service.js b/app/services/matrices-service.js
@@ -216,7 +216,6 @@ exports.retrieveVersionById = function(stixId, modified, callback) {
 
 let retrieveTacticById;
 let retrieveTechniquesForTactic;
-exports.retrieveVersionTechniquesById = true;
 exports.retrieveVersionTechniquesById = async function(stixId, modified, callback) {
     // Retrieve the versions of the matrix techniques with the matching stixId and modified date
 
@@ -256,15 +255,15 @@ exports.retrieveVersionTechniquesById = async function(stixId, modified, callbac
             if (matrix) {
                 // get tactics, then query for techniques and sub-techniques
                 const options = { versions: 'latest', offset: 0, limit: 0 };
-                let tactics_techniques = {};
+                const tactics_techniques = {};
                 for (const tactic_id of matrix['stix']['tactic_refs']) {
                     let tactic = await retrieveTacticById(tactic_id, options);
                     if (tactic) {
                         tactic = tactic[0];
-                        let techniques = await retrieveTechniquesForTactic(tactic_id, tactic['stix']['modified'], options);
+                        const techniques = await retrieveTechniquesForTactic(tactic_id, tactic['stix']['modified'], options);
                         // Organize sub-techniques under super techniques
-                        let super_techniques = [];
-                        let sub_techniques = [];
+                        const super_techniques = [];
+                        const sub_techniques = [];
                         for (const technique of techniques) {
                             if (technique['stix']['x_mitre_is_subtechnique'] === false) {
                                 super_techniques.push(technique);