treewide: Fix warnings

Signed-off-by: celtare21 <[email protected]>

drivers/pci/controller/dwc/pcie-exynos-rc.c

@@ -2048,7 +2048,6 @@ void exynos_pcie_rc_cpl_timeout_work(struct work_struct *work)
 		container_of(work, struct exynos_pcie, cpl_timeout_work.work);
 	struct dw_pcie *pci = exynos_pcie->pci;
 	struct pcie_port *pp = &pci->pp;
-	struct device *dev = pci->dev;
 
 	if (exynos_pcie->state == STATE_LINK_DOWN)
 		return;
@@ -3522,7 +3521,6 @@ EXPORT_SYMBOL_GPL(exynos_pcie_rc_l1ss_ctrl);
 int exynos_pcie_poweron(int ch_num, int spd)
 {
 	struct exynos_pcie *exynos_pcie = &g_pcie_rc[ch_num];
-	struct dw_pcie *pci = exynos_pcie->pci;
 
 	dev_dbg(pci->dev, "%s requested with link speed GEN%d\n", __func__, spd);
 	exynos_pcie->max_link_speed = spd;

drivers/scsi/scsi_sysfs.c

@@ -370,7 +370,7 @@ static DEVICE_ATTR(eh_deadline, S_IRUGO | S_IWUSR, show_shost_eh_deadline, store
 
 shost_rd_attr(unique_id, "%u\n");
 shost_rd_attr(cmd_per_lun, "%hd\n");
-shost_rd_attr(can_queue, "%hd\n");
+shost_rd_attr(can_queue, "%d\n");
 shost_rd_attr(sg_tablesize, "%hu\n");
 shost_rd_attr(sg_prot_tablesize, "%hu\n");
 shost_rd_attr(unchecked_isa_dma, "%d\n");

drivers/scsi/ufs/ufshcd.c

@@ -6656,21 +6656,6 @@ struct ctm_info {
 	unsigned int	ncpl;
 };
 
-static bool ufshcd_compl_tm(struct request *req, void *priv, bool reserved)
-{
-	struct ctm_info *const ci = priv;
-	struct completion *c;
-
-	WARN_ON_ONCE(reserved);
-	if (test_bit(req->tag, &ci->pending))
-		return true;
-	ci->ncpl++;
-	c = req->end_io_data;
-	if (c)
-		complete(c);
-	return true;
-}
-
 /**
  * ufshcd_tmc_handler - handle task management function completion
  * @hba: per adapter instance

net/8021q/vlanproc.c

@@ -252,7 +252,7 @@ static int vlandev_seq_show(struct seq_file *seq, void *offset)
 
 	stats = dev_get_stats(vlandev, &temp);
 	seq_printf(seq,
-		   "%s  VID: %d	 REORDER_HDR: %i  dev->priv_flags: %hx\n",
+		   "%s  VID: %d	 REORDER_HDR: %i  dev->priv_flags: %ux\n",
 		   vlandev->name, vlan->vlan_id,
 		   (int)(vlan->flags & 1), vlandev->priv_flags);
 

net/ipv4/esp4.c

@@ -1116,10 +1116,6 @@ static int esp_init_authenc(struct xfrm_state *x)
 		err = -EINVAL;
 		if (aalg_desc->uinfo.auth.icv_fullbits / 8 !=
 		    crypto_aead_authsize(aead)) {
-			pr_info("ESP: %s digestsize %u != %hu\n",
-				x->aalg->alg_name,
-				crypto_aead_authsize(aead),
-				aalg_desc->uinfo.auth.icv_fullbits / 8);
 			goto free_key;
 		}
 

net/ipv4/netfilter/nf_nat_h323.c

@@ -156,10 +156,6 @@ static int set_ras_addr(struct sk_buff *skb, struct nf_conn *ct,
 		if (get_h225_addr(ct, *data, &taddr[i], &addr, &port) &&
 		    addr.ip == ct->tuplehash[dir].tuple.src.u3.ip &&
 		    port == ct->tuplehash[dir].tuple.src.u.udp.port) {
-			pr_debug("nf_nat_ras: set rasAddress %pI4:%hu->%pI4:%hu\n",
-				 &addr.ip, ntohs(port),
-				 &ct->tuplehash[!dir].tuple.dst.u3.ip,
-				 ntohs(ct->tuplehash[!dir].tuple.dst.u.udp.port));
 			return set_h225_addr(skb, protoff, data, 0, &taddr[i],
 					     &ct->tuplehash[!dir].tuple.dst.u3,
 					     ct->tuplehash[!dir].tuple.
@@ -261,18 +257,6 @@ static int nat_rtp_rtcp(struct sk_buff *skb, struct nf_conn *ct,
 	info->rtp_port[i][dir] = rtp_port;
 	info->rtp_port[i][!dir] = htons(nated_port);
 
-	/* Success */
-	pr_debug("nf_nat_h323: expect RTP %pI4:%hu->%pI4:%hu\n",
-		 &rtp_exp->tuple.src.u3.ip,
-		 ntohs(rtp_exp->tuple.src.u.udp.port),
-		 &rtp_exp->tuple.dst.u3.ip,
-		 ntohs(rtp_exp->tuple.dst.u.udp.port));
-	pr_debug("nf_nat_h323: expect RTCP %pI4:%hu->%pI4:%hu\n",
-		 &rtcp_exp->tuple.src.u3.ip,
-		 ntohs(rtcp_exp->tuple.src.u.udp.port),
-		 &rtcp_exp->tuple.dst.u3.ip,
-		 ntohs(rtcp_exp->tuple.dst.u.udp.port));
-
 	return 0;
 }
 
@@ -318,12 +302,6 @@ static int nat_t120(struct sk_buff *skb, struct nf_conn *ct,
 		return -1;
 	}
 
-	pr_debug("nf_nat_h323: expect T.120 %pI4:%hu->%pI4:%hu\n",
-		 &exp->tuple.src.u3.ip,
-		 ntohs(exp->tuple.src.u.tcp.port),
-		 &exp->tuple.dst.u3.ip,
-		 ntohs(exp->tuple.dst.u.tcp.port));
-
 	return 0;
 }
 
@@ -378,12 +356,6 @@ static int nat_h245(struct sk_buff *skb, struct nf_conn *ct,
 	info->sig_port[dir] = port;
 	info->sig_port[!dir] = htons(nated_port);
 
-	pr_debug("nf_nat_q931: expect H.245 %pI4:%hu->%pI4:%hu\n",
-		 &exp->tuple.src.u3.ip,
-		 ntohs(exp->tuple.src.u.tcp.port),
-		 &exp->tuple.dst.u3.ip,
-		 ntohs(exp->tuple.dst.u.tcp.port));
-
 	return 0;
 }
 
@@ -482,13 +454,6 @@ static int nat_q931(struct sk_buff *skb, struct nf_conn *ct,
 		}
 	}
 
-	/* Success */
-	pr_debug("nf_nat_ras: expect Q.931 %pI4:%hu->%pI4:%hu\n",
-		 &exp->tuple.src.u3.ip,
-		 ntohs(exp->tuple.src.u.tcp.port),
-		 &exp->tuple.dst.u3.ip,
-		 ntohs(exp->tuple.dst.u.tcp.port));
-
 	return 0;
 }
 
@@ -559,13 +524,6 @@ static int nat_callforwarding(struct sk_buff *skb, struct nf_conn *ct,
 		return -1;
 	}
 
-	/* Success */
-	pr_debug("nf_nat_q931: expect Call Forwarding %pI4:%hu->%pI4:%hu\n",
-		 &exp->tuple.src.u3.ip,
-		 ntohs(exp->tuple.src.u.tcp.port),
-		 &exp->tuple.dst.u3.ip,
-		 ntohs(exp->tuple.dst.u.tcp.port));
-
 	return 0;
 }
 

net/ipv6/esp6.c

@@ -1158,10 +1158,6 @@ static int esp_init_authenc(struct xfrm_state *x)
 		err = -EINVAL;
 		if (aalg_desc->uinfo.auth.icv_fullbits / 8 !=
 		    crypto_aead_authsize(aead)) {
-			pr_info("ESP: %s digestsize %u != %hu\n",
-				x->aalg->alg_name,
-				crypto_aead_authsize(aead),
-				aalg_desc->uinfo.auth.icv_fullbits / 8);
 			goto free_key;
 		}
 

net/l2tp/l2tp_ppp.c

@@ -1554,7 +1554,7 @@ static void pppol2tp_seq_session_show(struct seq_file *m, void *v)
 		   session->lns_mode ? "LNS" : "LAC",
 		   0,
 		   jiffies_to_msecs(session->reorder_timeout));
-	seq_printf(m, "   %hu/%hu %ld/%ld/%ld %ld/%ld/%ld\n",
+	seq_printf(m, "   %du/%du %ld/%ld/%ld %ld/%ld/%ld\n",
 		   session->nr, session->ns,
 		   atomic_long_read(&session->stats.tx_packets),
 		   atomic_long_read(&session->stats.tx_bytes),

net/netfilter/nf_conntrack_h323_main.c

@@ -192,9 +192,6 @@ static int get_tpkt_data(struct sk_buff *skb, unsigned int protoff,
 	if (tpktlen > tcpdatalen) {
 		if (tcpdatalen == 4) {	/* Separate TPKT header */
 			/* Netmeeting sends TPKT header and data separately */
-			pr_debug("nf_ct_h323: separate TPKT header indicates "
-				 "there will be TPKT data of %hu bytes\n",
-				 tpktlen - 4);
 			info->tpkt_len[dir] = tpktlen - 4;
 			return 0;
 		}
@@ -866,9 +863,6 @@ static int process_setup(struct sk_buff *skb, struct nf_conn *ct,
 	    get_h225_addr(ct, *data, &setup->destCallSignalAddress,
 			  &addr, &port) &&
 	    memcmp(&addr, &ct->tuplehash[!dir].tuple.src.u3, sizeof(addr))) {
-		pr_debug("nf_ct_q931: set destCallSignalAddress %pI6:%hu->%pI6:%hu\n",
-			 &addr, ntohs(port), &ct->tuplehash[!dir].tuple.src.u3,
-			 ntohs(ct->tuplehash[!dir].tuple.src.u.tcp.port));
 		ret = set_h225_addr(skb, protoff, data, dataoff,
 				    &setup->destCallSignalAddress,
 				    &ct->tuplehash[!dir].tuple.src.u3,
@@ -883,9 +877,6 @@ static int process_setup(struct sk_buff *skb, struct nf_conn *ct,
 	    get_h225_addr(ct, *data, &setup->sourceCallSignalAddress,
 			  &addr, &port) &&
 	    memcmp(&addr, &ct->tuplehash[!dir].tuple.dst.u3, sizeof(addr))) {
-		pr_debug("nf_ct_q931: set sourceCallSignalAddress %pI6:%hu->%pI6:%hu\n",
-			 &addr, ntohs(port), &ct->tuplehash[!dir].tuple.dst.u3,
-			 ntohs(ct->tuplehash[!dir].tuple.dst.u.tcp.port));
 		ret = set_h225_addr(skb, protoff, data, dataoff,
 				    &setup->sourceCallSignalAddress,
 				    &ct->tuplehash[!dir].tuple.dst.u3,

net/netfilter/nf_conntrack_standalone.c

@@ -56,24 +56,24 @@ print_tuple(struct seq_file *s, const struct nf_conntrack_tuple *tuple,
 			   ntohs(tuple->src.u.icmp.id));
 		break;
 	case IPPROTO_TCP:
-		seq_printf(s, "sport=%hu dport=%hu ",
+		seq_printf(s, "sport=%d dport=%d ",
 			   ntohs(tuple->src.u.tcp.port),
 			   ntohs(tuple->dst.u.tcp.port));
 		break;
 	case IPPROTO_UDPLITE:
 	case IPPROTO_UDP:
-		seq_printf(s, "sport=%hu dport=%hu ",
+		seq_printf(s, "sport=%d dport=%d ",
 			   ntohs(tuple->src.u.udp.port),
 			   ntohs(tuple->dst.u.udp.port));
 
 		break;
 	case IPPROTO_DCCP:
-		seq_printf(s, "sport=%hu dport=%hu ",
+		seq_printf(s, "sport=%d dport=%d ",
 			   ntohs(tuple->src.u.dccp.port),
 			   ntohs(tuple->dst.u.dccp.port));
 		break;
 	case IPPROTO_SCTP:
-		seq_printf(s, "sport=%hu dport=%hu ",
+		seq_printf(s, "sport=%d dport=%d ",
 			   ntohs(tuple->src.u.sctp.port),
 			   ntohs(tuple->dst.u.sctp.port));
 		break;

net/netfilter/xt_TPROXY.c

@@ -75,17 +75,10 @@ tproxy_tg4(struct net *net, struct sk_buff *skb, __be32 laddr, __be16 lport,
 		   targets on the same rule yet */
 		skb->mark = (skb->mark & ~mark_mask) ^ mark_value;
 
-		pr_debug("redirecting: proto %hhu %pI4:%hu -> %pI4:%hu, mark: %x\n",
-			 iph->protocol, &iph->daddr, ntohs(hp->dest),
-			 &laddr, ntohs(lport), skb->mark);
-
 		nf_tproxy_assign_sock(skb, sk);
 		return NF_ACCEPT;
 	}
 
-	pr_debug("no socket, dropping: proto %hhu %pI4:%hu -> %pI4:%hu, mark: %x\n",
-		 iph->protocol, &iph->saddr, ntohs(hp->source),
-		 &iph->daddr, ntohs(hp->dest), skb->mark);
 	return NF_DROP;
 }
 
@@ -169,18 +162,10 @@ tproxy_tg6_v1(struct sk_buff *skb, const struct xt_action_param *par)
 		   targets on the same rule yet */
 		skb->mark = (skb->mark & ~tgi->mark_mask) ^ tgi->mark_value;
 
-		pr_debug("redirecting: proto %hhu %pI6:%hu -> %pI6:%hu, mark: %x\n",
-			 tproto, &iph->saddr, ntohs(hp->source),
-			 laddr, ntohs(lport), skb->mark);
-
 		nf_tproxy_assign_sock(skb, sk);
 		return NF_ACCEPT;
 	}
 
-	pr_debug("no socket, dropping: proto %hhu %pI6:%hu -> %pI6:%hu, mark: %x\n",
-		 tproto, &iph->saddr, ntohs(hp->source),
-		 &iph->daddr, ntohs(hp->dest), skb->mark);
-
 	return NF_DROP;
 }