Skip to content

Commit

Permalink
yes use mock for 1 test run and not for other
Browse files Browse the repository at this point in the history
  • Loading branch information
@aaronmgdr
aaronmgdr committed Jan 22, 2025
1 parent 6eb03e6 commit 400a531
Show file tree
Hide file tree
Showing 3 changed files with 73 additions and 40 deletions.
52 changes: 26 additions & 26 deletions packages/cli/src/commands/network/__snapshots__/contracts-l2.test.ts.snap
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`network:contracts runs 1`] = `
exports[`network:contracts when version can be obtained runs 2`] = `
[
[
"[
Expand Down Expand Up @@ -210,73 +210,73 @@ exports[`network:contracts when version cant be obtained still prints rest of co
"contract": "Accounts",
"proxy": "0x6e31AE4b9cC7A90ae038b8FBBEd2Eb95104BA8aE",
"implementation": "0x8b2172Dd4eEA915EFc7dCD186E1cC96B8D7E1632",
"version": "1.1.4.2"
"version": "1.2.3.4"
},
{
"contract": "BlockchainParameters",
"proxy": "0xff32a62a9f303e3cB4985CCbEA9122f320EcD154",
"implementation": "0x981E260e7a2d7a83C8F4bA78B40cc97AAB95EDF7",
"version": "1.3.1.0"
"version": "1.2.3.4"
},
{
"contract": "CeloUnreleasedTreasury",
"proxy": "0x621b99D7698395aD1A677d981a7F7Ae66cB4861f",
"implementation": "0x4657793c02091974B42d28aA46225A81c113C0C2",
"version": "1.1.0.0"
"version": "1.2.3.4"
},
{
"contract": "DoubleSigningSlasher",
"proxy": "0x96402dEDCcA832F2874E0fD9626cba302B7495bB",
"implementation": "0x1e96753a534436d7D09bB5f0c9f2e7081A35bd4E",
"version": "1.1.1.1"
"version": "1.2.3.4"
},
{
"contract": "DowntimeSlasher",
"proxy": "0x1c82668A47EF53655fC7b473e39a6f8E46E8C154",
"implementation": "0xa1F0F1F2138007695f943872A502ae96ff1Ee9df",
"version": "2.0.0.1"
"version": "1.2.3.4"
},
{
"contract": "Election",
"proxy": "0xcB4E4A207DC1C220bd54B2A983E32e923c32E544",
"implementation": "0x6710D9980C55D7963B4dA671A159523BB5b4F6d1",
"version": "1.1.4.0"
"version": "1.2.3.4"
},
{
"contract": "EpochManager",
"proxy": "0x2E290D8c2D6b26985f2826A63Aa103963DbAca23",
"implementation": "0x7B6F67483366a3D328B17055afcD664Cf0FFAE4E",
"version": "1.1.0.0"
"version": "1.2.3.4"
},
{
"contract": "EpochManagerEnabler",
"proxy": "0xeD2E802c08227c1b3DA3F502Ed9dcAA01616309B",
"implementation": "0x3fFcB4bf2D76C659Aea8AC6667C0C611576284aA",
"version": "1.1.0.0"
"version": "1.2.3.4"
},
{
"contract": "EpochRewards",
"proxy": "0x535D5EbB846832A2d876380dBccCb84eE5521d3f",
"implementation": "0xB4C3e97Ee2acaeb7D840Fde692465903239f213E",
"version": "1.1.2.0"
"version": "1.2.3.4"
},
{
"contract": "Escrow",
"proxy": "0x69EeE27C1ace51A7a5306D41262D16B6838aDd88",
"implementation": "0xdc359C2E9586B93Ab41fC180079E6485Bc8963Fb",
"version": "1.2.0.0"
"version": "1.2.3.4"
},
{
"contract": "FederatedAttestations",
"proxy": "0x2972DF87DA881bf2E71ea8aF6dE6E8b2731e13e9",
"implementation": "0x6319822f850f649F23b6d2ABE6d3c68D26a11679",
"version": "1.1.0.0"
"version": "1.2.3.4"
},
{
"contract": "FeeCurrencyDirectory",
"proxy": "0x5a7D21C9255DAA32109c8136661D7e853Fc5BF63",
"implementation": "0x4f9BaCe3eaC4917Ee4427a376E84d9A47428ce19",
"version": "1.1.0.0"
"version": "1.2.3.4"
},
{
"contract": "FeeCurrencyWhitelist",
Expand All @@ -288,7 +288,7 @@ exports[`network:contracts when version cant be obtained still prints rest of co
"contract": "FeeHandler",
"proxy": "0xeaEEC408eCbCdF9CDF21d0B1880419dF7290E2c9",
"implementation": "0x2e647D9D128c89D7239fdF47ca290453ad5869df",
"version": "1.2.0.0"
"version": "1.2.3.4"
},
{
"contract": "Freezer",
Expand All @@ -300,19 +300,19 @@ exports[`network:contracts when version cant be obtained still prints rest of co
"contract": "GasPriceMinimum",
"proxy": "0x9220E1A69bF1b9A26041ff582b7AdC4124D8364f",
"implementation": "0x541Cdf8Dd40cEC9bAF3824001776A0C4f842c08B",
"version": "1.2.1.0"
"version": "1.2.3.4"
},
{
"contract": "GoldToken",
"proxy": "0x84afC656f046C38D6022C2f02b9F667f028e1ef0",
"implementation": "0xd83c2018543B661B6e96810ca1B8b87a4B01e1a8",
"version": "1.1.3.0"
"version": "1.2.3.4"
},
{
"contract": "Governance",
"proxy": "0x2EB25B5eb9d5A4f61deb1e4F846343F862eB67D9",
"implementation": "0x063BDb2e9A86e8aD2ad9fc488e9E45Dc2a845c3a",
"version": "1.4.2.0"
"version": "1.2.3.4"
},
{
"contract": "GovernanceSlasher",
Expand All @@ -324,25 +324,25 @@ exports[`network:contracts when version cant be obtained still prints rest of co
"contract": "LockedGold",
"proxy": "0x619b4767f6A955E63ED7d334DF3384bc4eacFdB8",
"implementation": "0x3E526b2BD8A56696C0370daE4CB023eDb19DC647",
"version": "1.1.5.0"
"version": "1.2.3.4"
},
{
"contract": "MentoFeeHandlerSeller",
"proxy": "0x4b08c6219147552F68A3D4CA0ab4737B531660e4",
"implementation": "0x5d301e716d607a0c43B8DfF4d6102a13c18FA961",
"version": "1.1.1.0"
"version": "1.2.3.4"
},
{
"contract": "OdisPayments",
"proxy": "0x8Cc7e63482Ca6Ee77E0D1820395289D07249de77",
"implementation": "0x5683019ff6BCEaaC2badD1d73F6Ff28500079b41",
"version": "1.1.0.0"
"version": "1.2.3.4"
},
{
"contract": "Random",
"proxy": "0xA9DB88ADd5d6910183F38D5d0A451868898C7C82",
"implementation": "0x93D3Af5d5aAb66fAeF41A9242E12307D1813d2B3",
"version": "1.1.2.0"
"version": "1.2.3.4"
},
{
"contract": "Registry",
Expand All @@ -354,19 +354,19 @@ exports[`network:contracts when version cant be obtained still prints rest of co
"contract": "Reserve",
"proxy": "0x153193d9b852Dd791565a2929110282976040e54",
"implementation": "0x6DDBd2A88C55e28ac8283c43D1F7100C295283fb",
"version": "1.1.2.2"
"version": "1.2.3.4"
},
{
"contract": "ScoreManager",
"proxy": "0x26B262FbaB2E243a4CEFD2Dbde9e1C203BaCd732",
"implementation": "0x345E7101aa60eDe5864822FC3fb2E5d5f679C187",
"version": "1.1.0.0"
"version": "1.2.3.4"
},
{
"contract": "SortedOracles",
"proxy": "0xeA6aCD469A2C2F32E167a9Ce50db735B61e00A2a",
"implementation": "0x19f9025D0eF2Ea2025b51DCB7CEEC4845aaf2A5e",
"version": "1.1.4.0"
"version": "1.2.3.4"
},
{
"contract": "StableToken",
Expand All @@ -390,13 +390,13 @@ exports[`network:contracts when version cant be obtained still prints rest of co
"contract": "UniswapFeeHandlerSeller",
"proxy": "0x33f9eFcF4d4834932D3958d6d1d5AE18F358406E",
"implementation": "0xfFcE963152Faf3e797a71582Ef6419a7E6204542",
"version": "2.0.0.0"
"version": "1.2.3.4"
},
{
"contract": "Validators",
"proxy": "0x0fEDbA6Ae0D2cD916FaB191aA822cf9fe41990Be",
"implementation": "0x2b8669A7f7066507a140CD4D60D1946ff864A0B0",
"version": "1.3.0.0"
"version": "1.2.3.4"
}
]
",
Expand Down
59 changes: 46 additions & 13 deletions packages/cli/src/commands/network/contracts-l2.test.ts
View file
Original file line number Diff line number Diff line change
@@ -1,31 +1,64 @@
import { newICeloVersionedContract } from '@celo/abis/web3/ICeloVersionedContract'
import { testWithAnvilL2 } from '@celo/dev-utils/lib/anvil-test'
import write from '@oclif/core/lib/cli-ux/write'
import { testLocallyWithWeb3Node } from '../../test-utils/cliUtils'
import Contracts from './contracts'
process.env.NO_SYNCCHECK = 'true'
jest.mock('@celo/abis/web3/ICeloVersionedContract')

testWithAnvilL2('network:contracts', (web3) => {
test('runs', async () => {
const spy = jest.spyOn(write, 'stdout')
await testLocallyWithWeb3Node(Contracts, ['--output', 'json'], web3)
expect(spy.mock.calls).toMatchSnapshot()
})
describe('when version cant be obtained', () => {
it('still prints rest of contracts', async () => {
describe('when version can be obtained', () => {
beforeEach(() => {
jest.unmock('@celo/abis/web3/ICeloVersionedContract')
jest.resetModules()
const actual = jest.requireActual('@celo/abis/web3/ICeloVersionedContract')
// @ts-expect-error
newICeloVersionedContract.mockImplementation(actual.newICeloVersionedContract)
})
test('runs', async () => {
const spy = jest.spyOn(write, 'stdout')
const warnSpy = jest.spyOn(console, 'warn')
jest.mock('@celo/abis/web3/ICeloVersionedContract', () => {
expect(warnSpy.mock.calls).toMatchInlineSnapshot(`[]`)
await testLocallyWithWeb3Node(Contracts, ['--output', 'json'], web3)
expect(spy.mock.calls).toMatchSnapshot()
})
})
describe('when version cant be obtained', () => {
beforeEach(() => {
// @ts-expect-error
newICeloVersionedContract.mockImplementation((_, address) => {
return {
newICeloVersionedContract: {
getVersionNumber: () => {
throw new Error('method not found')
},
methods: {
getVersionNumber: jest.fn().mockImplementation(() => {
// fake governance slasher
if (address === '0x76C05a43234EB2804aa83Cd40BA10080a43d07AE') {
return { call: jest.fn().mockRejectedValue(new Error('Error: execution reverted')) }
} else {
// return a fake normal version
return { call: jest.fn().mockResolvedValue([1, 2, 3, 4]) }
}
}),
},
}
})
})
afterEach(() => {
jest.clearAllMocks()
jest.resetModules()
})
it('still prints rest of contracts', async () => {
const spy = jest.spyOn(write, 'stdout')
const warnSpy = jest.spyOn(console, 'warn')

// @ts-ignore
await testLocallyWithWeb3Node(Contracts, ['--output', 'json'], web3)
expect(warnSpy.mock.calls).toMatchInlineSnapshot(`[]`)
expect(warnSpy.mock.calls).toMatchInlineSnapshot(`
[
[
"Failed to get version for GovernanceSlasher at 0xDDA88a8ebeaaB19d2a58374D8c72200AFAF94bB4",
],
]
`)
expect(spy.mock.calls).toMatchSnapshot() // see the file for the snapshot
})
})
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/commands/network/contracts.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export default class Contracts extends BaseCommand {
version = `${raw[0]}.${raw[1]}.${raw[2]}.${raw[3]}`
} catch (e) {
console.warn(`Failed to get version for ${contract} at ${proxy}`)
version = contract === CeloContract.GovernanceSlasher ? '1.1.0.0' : 'NONE'
version = contract === CeloContract.GovernanceSlasher ? '1.1.1.0' : 'UNKNOWN'
}
}

Expand Down

0 comments on commit 400a531

Please sign in to comment.