fix(syncer): don't Head recursively #248
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wondertan
requested review from
tzdybal,
renaynay,
vgonkivs,
gupadhyaya,
walldiss and
cristaloleg
as code owners
cristaloleg
reviewed
Feb 14, 2025
| } | ||
|
|
||
| func (e errorGetter) Get(ctx context.Context, hash header.Hash) (*headertest.DummyHeader, error) { | ||
| //TODO implement me |
cristaloleg
reviewed
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need recursion here. If recent head request fails, all the waiters should simply return any known subjective head, like with other error cases.
Closes #247