-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: change node requirements #1868
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe documentation for Celestia node types has been comprehensively updated to reflect increased hardware requirements. Across multiple node-specific guides (bridge, consensus, full storage, and validator nodes), the minimum specifications have been elevated, with notable increases in RAM from 16 GB to 24 GB, CPU cores from quad-core to 8 cores, and disk storage from 2 TB to 3-5 TiB, depending on the node type. Changes
Possibly related issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
how-to-guides/bridge-node.md
(1 hunks)how-to-guides/consensus-node.md
(1 hunks)how-to-guides/full-storage-node.md
(1 hunks)how-to-guides/nodes-overview.md
(1 hunks)how-to-guides/validator-node.md
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (3)
how-to-guides/nodes-overview.md (1)
39-40
: Hardware requirements are consistently updated across node types.The updated requirements align with the PR objectives:
- DA Layer nodes (Bridge & Full storage): 24GB RAM, 8 cores, 5 TiB NVME
- Consensus Layer nodes (Validator & Consensus): 24GB RAM, 8 cores, 3 TiB SSD
Also applies to: 46-47
how-to-guides/validator-node.md (1)
22-24
: Hardware requirements match nodes-overview.md.The updated requirements for validator nodes are consistent with the overview document.
how-to-guides/consensus-node.md (1)
24-26
: Hardware requirements match nodes-overview.md.The updated requirements for consensus nodes are consistent with the overview document.
- Memory: **24 GB RAM (minimum)** | ||
- CPU: **6 cores** | ||
- Disk: **2 TB NVME Storage** | ||
- Disk: **5 TiB NVME Storage** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent CPU requirement with nodes-overview.md.
The CPU requirement here is 6 cores, while nodes-overview.md specifies 8 cores for full storage nodes.
Please update the CPU requirement to match:
- CPU: **6 cores**
+ CPU: **8 cores**
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
- Memory: **24 GB RAM (minimum)** | |
- CPU: **6 cores** | |
- Disk: **2 TB NVME Storage** | |
- Disk: **5 TiB NVME Storage** | |
- Memory: **24 GB RAM (minimum)** | |
- CPU: **8 cores** | |
- Disk: **5 TiB NVME Storage** |
- Memory: **24 GB RAM (minimum)** | ||
- CPU: **6 cores** | ||
- Disk: **2 TB NVME Storage** | ||
- Disk: **5 TiB NVME Storage** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent CPU requirement with nodes-overview.md.
The CPU requirement here is 6 cores, while nodes-overview.md specifies 8 cores for bridge nodes.
Please update the CPU requirement to match:
- CPU: **6 cores**
+ CPU: **8 cores**
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
- Memory: **24 GB RAM (minimum)** | |
- CPU: **6 cores** | |
- Disk: **2 TB NVME Storage** | |
- Disk: **5 TiB NVME Storage** | |
- Memory: **24 GB RAM (minimum)** | |
- CPU: **8 cores** | |
- Disk: **5 TiB NVME Storage** |
Overview
Updates node requirements to:
Summary by CodeRabbit