comply with libphonenumber's mainCountryForCode attribute when formatting numbers #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cedvdb let me know what you think |
|
great ! |
cedvdb
reviewed
Sep 24, 2024
| @@ -35,6 +35,12 @@ void main() { | |||
| } | |||
| }); | |||
|
|
|||
| test('should get formats metadata for iso code going through references', | |||
There was a problem hiding this comment.
Could you add a more high level test in phone_number_test for the expected format behavior, for example for a canadian phone number ?
There was a problem hiding this comment.
Absolutely! Incoming.
|
Sorry for the delay, I added a small comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see:
https://github.com/google/libphonenumber/blob/55716be400990f6542112323134cc1abc58abc2e/making-metadata-changes.md?plain=1#L34
Fixes: #74