Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove special characters from docker container names #265

Merged
merged 1 commit into from
Dec 18, 2023
Merged

remove special characters from docker container names #265

merged 1 commit into from
Dec 18, 2023

Conversation

xtuc
Copy link
Member

@xtuc xtuc commented Jun 22, 2023

Closes #264

@MattIPv4
Copy link
Member

cdnjs/packages#1143 (comment) failed due to a +. Would it not be better to filter down to anything that isn't [a-zA-Z0-9][a-zA-Z0-9_.-] per the error message, rather than removing specific characters each time we run into one?

@xtuc xtuc force-pushed the sven/container-name branch from 6828386 to af56dee Compare December 18, 2023 10:18
@xtuc xtuc changed the title remove @ from docker container names remove special characters from docker container names Dec 18, 2023
@xtuc
Copy link
Member Author

xtuc commented Dec 18, 2023

@MattIPv4 fixed

@xtuc xtuc merged commit dbe86eb into master Dec 18, 2023
8 checks passed
@xtuc xtuc deleted the sven/container-name branch December 18, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

process-version: incompatible docker container names
2 participants
@xtuc @MattIPv4