Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a simple pulsar source connector. #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add a simple pulsar source connector. #1

wants to merge 2 commits into from

Conversation

cckellogg
Copy link
Owner

@cckellogg cckellogg commented Jun 20, 2018 •
edited
Loading

What is the purpose of the change

This pull request adds a pulsar source connector which will enable flink jobs to process messages from pulsar topics.

Brief change log

  • Add a PulsarConsumerSource connector

Verifying this change

This change adds unit test to verify checkpointing and batch message acknowledgements.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? yes
  • If yes, how is the feature documented? JavaDocs

sijie
sijie approved these changes Jun 20, 2018
View reviewed changes
Copy link

@sijie sijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good!

...nk-connector-pulsar/src/main/java/org/apache/flink/streaming/connectors/pulsar/Defaults.java
*/
public class Defaults {

public static final String SERVICE_URL = "pulsar://localhost:6650";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think flink is using tab for indents if I remembered directly. it might be worth double-checking before you send the pull request.

...ink-connector-pulsar/src/main/java/org/apache/flink/streaming/connectors/pulsar/Metrics.java Outdated
@@ -0,0 +1,22 @@
package org.apache.flink.streaming.connectors.pulsar;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing apache header

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cckellogg @sijie