-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scda: Write and read block sections #201
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we do not want to copy the potentially very big data, we also offer a padding function that only sets the padding bytes but does not copy the input data. For the fixed-length padding the data sizes are smaller and known in advance. That is why, we prefer the inplace padding for the fixed-length padding. However, for the sakes of flexibility and symmetry we will also add non-inplace function for the fixed-length padding.
As announced in the commit description of db724ac we add the analogous changes for the fixed-length paddding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scda: Write and read block sections
This PR continues the implementation of the scda file format (cf. #199) by introducing the functionalities for writing and reading block sections. The changes in this PR are in particular
fwrite_block
andfread_block_data
,fread_section_header
to also handle block section headers,fwrite_block
since the block data is allocated by the user and inplace padding would thus require a copy of the block data.sc_scda_pad_to_mod_len
to the caseSC_SCDA_PADDING_MOD < 7
.