resync from origin #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tristan Su <[email protected]>
Various make targets call '$(GO_BUILD)' but there is no facility for specifying arguments to 'go build'. As a first step, introduce the GCFLAGS Makefile variable that when unset, operates as always, but when set, adds '-gcflags "$(GCFLAGS)"' to go build. Eg, when unspecified, maintain the current behavior: $ make ... env GO111MODULE=on go build -tags ... -ldflags ... When specified, add the specified -gcflags: $ GCFLAGS="all=-N -l" make ... env GO111MODULE=on go build -tags ... -gcflags "all=-N -l" -ldflags ... This could be useful in various situations such as producing unoptimized builds (like in the above). In addition, remove the now unused (since cmd/influx was removed) GO_BUILD_SM environment variable.
* build(flux): update flux to v0.132.0 * chore: suppress staticcheck for use of deprecated proto package This package will be upgraded by this PR: #22571
* feat: show measurement database and retention policy wildcards Closes #22390 * chore: formatting * test: this commit fails tests with empty database * fix: show measurements with one empty database
…2590) * feat: influxd recovery-cli allows creating recovery user/token Closes #12051 * test: do not assert order of users or orgs in list * fix: code review suggestions from dan Co-authored-by: Daniel Moran <[email protected]> * fix: more fixes from dan's review * chore: depend on tabwriter from influx-cli * chore: revert onboarding refactor Co-authored-by: Daniel Moran <[email protected]>
* feat: return new operator token during backup overwrite * chore: update swagger * test: e2e restore test with new token
…ompatible 2.0.x cookie (#22632)
…to support fixed offsets (#22635) The pushdown does not support fixed offsets or non-UTC locations, but it does now correctly compile and pushdown other windows.
…2650) Add KV migration to repair missing shard-group durations
* feat: add bearer token support * fix: updating to use equalfold
It appears to be dead and not used anymore.
* fix: invalid assign to nil pointer * fix: close some files that were being left open * fix: lint
This fixes an occurrence of a loop variable being captured in a parallel test. With the previous code, only the last test case is actually exercised. To work around this problem, we create a local copy of the range variable before the parallel test, as suggested in the Go documentation for the `testing` package: https://pkg.go.dev/testing#hdr-Subtests_and_Sub_benchmarks Issue was found automatically using the `loopvarcapture` linter.
* chore: make tests robust to Flux formatter changes
* fix: set limited permissions on package installs * fix: set umask in systemd service to create files as 0750
* chore: add protoc-gen script to releng * chore: break cross-container-tag into separate variable * fix: call GNUMakefile "generate-sources" target instead This also does a better job at mounting the root directory in the docker container.
Signed-off-by: Abirdcfly <[email protected]> Signed-off-by: Abirdcfly <[email protected]>
Co-authored-by: Jeffrey Smith II <[email protected]>
* feat(security): set SameSite=strict on session cookie
Use SameSite=Strict as a hardening measure against cross-origin attacks.
While browsers have been moving to default to SameSite=Lax, explicitly
setting SameSite ensures that all browsers enforce it consistently.
While 'lax' is a reasonable hardening choice, the cookie is only
required for requests to '/api/...' and we don't expect 3rd party links
into '/api/...', so this stricter setting should be safe in terms of
usability. Furthermore, while our GET APIs are not state-changing, using
'strict' future-proofs us in case we add a state-changing GET API ('lax'
allows cross-origin 'GET' requests for increased usability for read-only
requests).
Also add a comment to SetCORS() lack of Access-Control-Allow-Credentials
as a reminder that its omission is intentional for defense in depth on
when to attach the cookie to a request.
* chore: mention that Lax sends the cookie with other safe HTTP methods
* fix: allow backup of all buckets * Revert "fix: allow backup of all buckets" This reverts commit 256ec2f. * fix: remove 20 item limit in several of the data stores * test: add a test for 20 item limit
* build(flux): update flux to v0.184.2 * chore: skip more Flux acceptance tests There are issues for each skip detailed in test-flux.sh.
* test: remove group skips * test: inline previously extended testcases that broke with added sort Some tests had a sort added so they'd pass in cloud, vanilla, and OSS. This also broke some extended testcases here in OSS since pushdown rules no longer match the plan. This diff "inlines" the testcase body for each of these so we get our coverage back, but leaves a FIXME to note that it would be better if we could somehow thread the needle and retain the extension.
* test(flux): set flux flagger in launcher * test(flux): use default flagger from vanilla * test(flux): unskip vectorized float tests * test(flux): remove redundant skips for already-tagged integration tests * test(flux): remove skips requiring `removeRedundantSortNodes` flag * test(flux): remove skips requiring `labelPolymorphism` flag
* fix: run manually scheduled tasks at their scheduled time * fix: actually use it * fix: get tests building * fix: fix tests * fix: lint
* fix: fixes an error querying virtual dbrps When the virtual pointer was set to false, the mappings were being ignored. * fix: missed part in a rebase * test: add test for shard mapping virtual dbrps * fix: do not create virtual mappings for equivalent physical mappings
…#23786) * fix: improve delete speed when a measurement is part of the predicate * test: add test for deleting measurement by predicate * chore: improve error messaging and capturing * chore: set goland to use the right formatting style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Describe your proposed changes here.