This repository has been archived by the owner on Aug 15, 2024. It is now read-only.
Add support for jQuery 3 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeer
reviewed
Jul 19, 2024
| @@ -15,5 +15,11 @@ | |||
| handler = 'page:load ready'; | |||
There was a problem hiding this comment.
Does this branch also need some handling?
There was a problem hiding this comment.
Yes, thanks. I saw "Turbolinks", and my eyes moved right over it...
taylor-steve
force-pushed
the
jquery-ready-change
branch
from
9b372e3 to
f50a6d5
Compare
taylor-steve
force-pushed
the
jquery-ready-change
branch
from
f50a6d5 to
61c291e
Compare
$(document).on("ready", handler) was deprecated in jQuery 1.8 and
removed in 3
taylor-steve
force-pushed
the
jquery-ready-change
branch
from
61c291e to
bb028f6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$(document).on("ready", handler) was deprecated in jQuery 1.8 and removed in 3.
https://api.jquery.com/ready/