Add Colour Shades Support #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now generates shades without including it on shade palette, which results in easier development and better shade palette. Now needs more testing. |
|
Well, will probably find another way of mapping interpolating values since too bright or too dark values still gets lightened/darkened, to the point they're completely white or black. |
catuhana
force-pushed
the
add/colour-shades
branch
from
6040ba0 to
ddbcedb
Compare
This implementation is not complete and code is *probably* bad. Will improve and fix remaining issues later.
Doesn't map and include the main colour anymore, since it's already present as `DEFAULT`.
This reverts commit 8d94cc7.
catuhana
force-pushed
the
add/colour-shades
branch
from
ddbcedb to
6826c70
Compare
catuhana
added
enhancement
|
Actually, closing this for now to get better ideas first from issues. I don't want this PR to be conflict fix challenge. |
catuhana
removed
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks fine for now. Might need to tune some values in [src/shade.ts]
mapLightnessToShadeRangefunction for better colour shade generation.