Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor extractProcess to use io.ReadAll instead of bufio.Reader #81

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

catatsuy
Copy link
Owner

This pull request includes changes to the internal/cli/cli.go file to improve the efficiency and readability of the extractProcess function. The most important changes include replacing the line-by-line reading with a single read operation and simplifying the error handling.

Code efficiency and readability improvements:

  • internal/cli/cli.go: Replaced the line-by-line reading of the input stream with a single read operation using io.ReadAll, which simplifies the code and potentially improves performance.
  • internal/cli/cli.go: Removed the loop and associated error handling for reading lines, as the entire input is now read at once.

@catatsuy catatsuy merged commit debd178 into main Nov 17, 2024
5 checks passed
@catatsuy catatsuy deleted the refactor-extractProcess-to-readAll branch November 17, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant