Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace error handling for EOF in CLI input processing with errors #79

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

catatsuy
Copy link
Owner

This pull request includes changes to the error handling in the replaceProcess and filterProcess methods of the CLI class in the internal/cli/cli.go file. The changes improve the readability and robustness of the error handling.

Error handling improvements:

  • internal/cli/cli.go: Added the errors package to handle errors more effectively.
  • internal/cli/cli.go: Modified the replaceProcess method to simplify the error handling logic by checking for io.EOF and other errors separately.
  • internal/cli/cli.go: Modified the filterProcess method to follow the same error handling pattern as replaceProcess, improving consistency and readability.

@catatsuy catatsuy merged commit a9a75ff into main Nov 17, 2024
5 checks passed
@catatsuy catatsuy deleted the feature-refactor-cli-error-handling branch November 17, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant