Merge pull request #48 from catatsuy/feature_provide_version_auto

provide the version automatically
catatsuy · Oct 30, 2019 · 6a50758 · 6a50758
2 parents 0d3216f + 13ca97e
commit 6a50758
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -25,7 +25,7 @@ jobs:
       - run: make vet
       - run: make test
       - run: make bin/notify_slack
-      - run: make release
+      - run: make release version=${CIRCLE_TAG}
 
       - persist_to_workspace:
           root: release/

diff --git a/Makefile b/Makefile
@@ -14,9 +14,9 @@ bin/output: cmd/output/main.go
 
 .PHONY: release
 release:
-	GOOS=linux go build -o notify_slack cmd/notify_slack/main.go
+	GOOS=linux go build -ldflags "-X github.com/catatsuy/notify_slack/cli.Version=${version}" -o notify_slack cmd/notify_slack/main.go
 	tar cvzf release/notify_slack-linux-amd64.tar.gz notify_slack
-	GOOS=darwin go build -o notify_slack cmd/notify_slack/main.go
+	GOOS=darwin go build -ldflags "-X github.com/catatsuy/notify_slack/cli.Version=${version}" -o notify_slack cmd/notify_slack/main.go
 	tar cvzf release/notify_slack-darwin-amd64.tar.gz notify_slack
 	rm notify_slack
 

diff --git a/README.md b/README.md
@@ -126,8 +126,6 @@ It will be useful if you want to use it on a container. If you use it, you don't
 
 ## Release
 
-Version of `cli/cli.go` will be updated.
-
 When you execute the following command and give a tag, it will be released via CircleCI.
 
 ``` sh

diff --git a/cli/cli.go b/cli/cli.go
@@ -17,9 +17,11 @@ import (
 	"github.com/catatsuy/notify_slack/throttle"
 )
 
-const (
-	Version = "v0.4.1"
+var (
+	Version string
+)
 
+const (
 	ExitCodeOK             = 0
 	ExitCodeParseFlagError = 1
 	ExitCodeFail           = 1
-Original file line number
+Diff line change
@@ Expand Up @@
     ## Release
-    Version of `cli/cli.go` will be updated.
     When you execute the following command and give a tag, it will be released via CircleCI.
     ``` sh
@@ Expand Down @@