Small re-organization of writing recording and sorting extractors tests #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have move further to have more isolated testing with in the spikeinterface module I think it would be a good idea to separate the previous tests that were added mainly to support writing extractors from
spikeextractors
(see catalystneuro/nwb-conversion-tools#182) into its own testing module. This PR does that by creating a new testing module calledtest_spikeextractors_to_nwb
which contains all the old tests and keeps the new tests ontest_si
.There are two advantages of this:
spikeinterface
objects vs testing writingspikeextractors
objects)test_si
module are way more isolated and unittest-like so they run faster. It is therefore faster to discover a failure without the need to run the slow tests of the spikeextractors which are some of the slowest tests onr our suite (see [Feature]: tests take a long time to run locally nwb-conversion-tools#449)