Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small re-organization of writing recording and sorting extractors tests #68

Merged
merged 2 commits into from
Aug 5, 2022

Conversation

h-mayorquin
Copy link
Collaborator

Now that we have move further to have more isolated testing with in the spikeinterface module I think it would be a good idea to separate the previous tests that were added mainly to support writing extractors from spikeextractors (see catalystneuro/nwb-conversion-tools#182) into its own testing module. This PR does that by creating a new testing module called test_spikeextractors_to_nwb which contains all the old tests and keeps the new tests on test_si.

There are two advantages of this:

  1. It would divide the tests for the function that they are providing (testing writing spikeinterface objects vs testing writing spikeextractors objects)
  2. The test in the test_si module are way more isolated and unittest-like so they run faster. It is therefore faster to discover a failure without the need to run the slow tests of the spikeextractors which are some of the slowest tests onr our suite (see [Feature]: tests take a long time to run locally nwb-conversion-tools#449)

@CodyCBakerPhD
Copy link
Member

Sure, fine by me. Will make cleanup easier when we eventually retire it altogether

@h-mayorquin h-mayorquin merged commit 36dc2f9 into main Aug 5, 2022
@h-mayorquin h-mayorquin deleted the re_organize_spikeinterface_tests branch August 5, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants