Add pynwb 3.0 support (#1231)

catalystneuro · Feb 27, 2025 · fa8a16f · fa8a16f
1 parent 0323835
commit fa8a16f
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,15 +14,17 @@ as used by hdmf >= 3.14.6.
 ## Features
 * Use the latest version of ndx-pose for `DeepLabCutInterface` and `LightningPoseDataInterface` [PR #1128](https://github.com/catalystneuro/neuroconv/pull/1128)
 * Added a first draft of `.clinerules` [#1229](https://github.com/catalystneuro/neuroconv/pull/1229)
+* Support for pynwb 3.0 [PR #1231](https://github.com/catalystneuro/neuroconv/pull/1231)
+* Support for hdmf 4.0 [PR #1204](https://github.com/catalystneuro/neuroconv/pull/1204)
+* Support for numpy 2.0 [PR #1206](https://github.com/catalystneuro/neuroconv/pull/1206)
+* Support Spikeinterface 0.102 [PR #1194](https://github.com/catalystneuro/neuroconv/pull/1194)
 
 ## Improvements
 * Simple writing no longer uses a context manager [PR #1180](https://github.com/catalystneuro/neuroconv/pull/1180)
 * Added Returns section to all getter docstrings [PR #1185](https://github.com/catalystneuro/neuroconv/pull/1185)
 * ElectricalSeries have better chunking defaults when data is passed as plain array [PR #1184](https://github.com/catalystneuro/neuroconv/pull/1184)
-* Support Spikeinterface 0.102 [PR #1194](https://github.com/catalystneuro/neuroconv/pull/1194)
 * Ophys interfaces now call `get_metadata` by default when no metadata is passed [PR #1200](https://github.com/catalystneuro/neuroconv/pull/1200)
-* Support for hdmf 4.0 [PR #1204](https://github.com/catalystneuro/neuroconv/pull/1204)
-* Support for numpy 2.0 [PR #1206](https://github.com/catalystneuro/neuroconv/pull/1206)
+
 
 
 # v0.6.7 (January 20, 2025)

diff --git a/src/neuroconv/datainterfaces/behavior/fictrac/fictracdatainterface.py b/src/neuroconv/datainterfaces/behavior/fictrac/fictracdatainterface.py
@@ -271,7 +271,7 @@ def add_to_nwbfile(
 
         # Add the container to the processing module
         processing_module = get_module(nwbfile=nwbfile, name="behavior")
-        processing_module.add_data_interface(position_container)
+        processing_module.add(position_container)
 
     def get_original_timestamps(self):
         """

diff --git a/...kend_and_dataset_configuration/test_helpers/test_get_default_dataset_io_configurations.py b/...kend_and_dataset_configuration/test_helpers/test_get_default_dataset_io_configurations.py
@@ -79,7 +79,7 @@ def test_configuration_on_electrical_series_with_non_wrapped_data(backend: Liter
 @pytest.mark.parametrize("backend", ["hdf5", "zarr"])
 def test_configuration_on_external_image_series(backend: Literal["hdf5", "zarr"]):
     nwbfile = mock_NWBFile()
-    image_series = ImageSeries(name="TestImageSeries", external_file=[""], rate=1.0)
+    image_series = ImageSeries(name="TestImageSeries", external_file=[""], rate=1.0, format="external")
     nwbfile.add_acquisition(image_series)
 
     dataset_configurations = list(get_default_dataset_io_configurations(nwbfile=nwbfile, backend=backend))

diff --git a/tests/test_on_data/icephys/test_gin_icephys.py b/tests/test_on_data/icephys/test_gin_icephys.py
@@ -110,7 +110,7 @@ class TestConverter(NWBConverter):
             self.check_set_aligned_starting_time()
             self.check_set_aligned_segment_starting_times()
 
-            assert nwbfile.ic_electrodes["electrode-0"].cell_id == "ID001"
+            assert nwbfile.icephys_electrodes["electrode-0"].cell_id == "ID001"
 
 
 if __name__ == "__main__":