Add SwiftUI View to SnapshotTests #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sherlouk
reviewed
Oct 17, 2020
Example/AccessibilitySnapshot/SwiftUIView+EmbedInHostingController.swift
Show resolved
Hide resolved
when snapshotting native SwiftUI is supported.
for equal indentation rules when the developers Xcode configuration is different from the default.
Sadly, `XCTSkipUnless` is only available for Xcode 11.4+.
to make SwiftUI not required for < iOS 13 Tests, found here https://stackoverflow.com/a/57907940
|
As Issue #33 seems to be a SwiftUI bug in iOS 14.0 and 14.1, this branch might not be needed anymore. But if you want, let's use it as a preparation for #37 because there are now two SwiftUI views which can be used for snapshot tests. And we now know when the SwiftUI bug is present again in newer iOS versions because we have a specific test for that. |
NickEntin
reviewed
Jan 8, 2021
Example/AccessibilitySnapshot/SwiftUIView+EmbedInHostingController.swift
Outdated
Show resolved
Hide resolved
Example/AccessibilitySnapshot/SwiftUIView+EmbedInHostingController.swift
Outdated
Show resolved
Hide resolved
Example/AccessibilitySnapshot/SwiftUIView+EmbedInHostingController.swift
Outdated
Show resolved
Hide resolved
Example/AccessibilitySnapshot/SwiftUIView+EmbedInHostingController.swift
Outdated
Show resolved
Hide resolved
…ller.swift Co-authored-by: Nick Entin <[email protected]>
…ller.swift Co-authored-by: Nick Entin <[email protected]>
Co-authored-by: Nick Entin <[email protected]>
…ller.swift Co-authored-by: Nick Entin <[email protected]>
NickEntin
approved these changes
Jan 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two SwiftUI Views as example for issue #33