Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Check existence of template content before formatting SMS content #48

Closed
wants to merge 3 commits into from

Conversation

mdilshan
Copy link

When there's no template code is selected in the SMS provider editor page, the formatted SMS body ended up with unnecessary characters.

image

This fix checks if the template code exists before formatting the code.

Note: Updated all places but only tested with Twillio as I only got Twillio account

@CLAassistant
Copy link

CLAassistant commented Nov 19, 2024

CLA assistant check
All committers have signed the CLA.

@hsluoyz
Copy link
Member

hsluoyz commented Nov 19, 2024

@mdilshan you are adding the same code to each implementation. Why not add the code in https://github.com/casdoor/casdoor ?

@hsluoyz
Copy link
Member

hsluoyz commented Nov 19, 2024

Should make it in: https://github.com/casdoor/casdoor , closed here

@hsluoyz hsluoyz closed this Nov 19, 2024
@mdilshan
Copy link
Author

@mdilshan you are adding the same code to each implementation. Why not add the code in https://github.com/casdoor/casdoor ?

Well the code is already duplicated ( Per each SMS provider ) in here, so went with the same pattern and only some SMS providers uses the template. So better to add it in here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants