Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix GetPaginationUsers error: "response data format is incorrect" #106

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

nasa1024
Copy link
Contributor

An error message response data format is incorrect appears when using the GetPaginationUsers function with the parameter "groupName": "xx". I have tried to fix it.

Error reproduction steps:

pUsers, count, err := casdoor.Cli.GetPaginationUsers(page, 100, map[string]string{
	"groupName": "xxx",
})

@casbin-bot
Copy link

@tangyang9464 @imp2002 please review

@CLAassistant
Copy link

CLAassistant commented Apr 17, 2024

CLA assistant check
All committers have signed the CLA.

@hsluoyz
Copy link
Member

hsluoyz commented Apr 18, 2024

@nasa1024 why is groupName so special? I didn't see anything wrong in the code.

And why did you do serialization and undo it again? So strange

image

@hsluoyz hsluoyz changed the title fix: GetPaginationUsers response data format is incorrect feat: fix GetPaginationUsers error: "response data format is incorrect" Apr 19, 2024
@hsluoyz hsluoyz merged commit 8987bae into casdoor:master Apr 19, 2024
4 checks passed
Copy link

🎉 This PR is included in version 0.42.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants