Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated blurbs for Hebrew, Southern Sotho, Korean and Latin #608

Merged
merged 5 commits into from
Jan 9, 2024

Conversation

elletjies
Copy link
Member

@froggleston I have updated the blurbs using Chat GPT. I first translated English into Hebrew, Southern Sotho, and Korean and then back-translated them.

@froggleston I have updated the blurbs using Chat GPT. I first translated English into Hebrew, Southern Sotho, and Korean, and then back-translated them again.
@elletjies elletjies requested a review from froggleston December 7, 2023 08:21
@elletjies elletjies changed the title Update _config.yml Updated blurbs for Hebrew, Southern Sotho and Korean Dec 7, 2023
@elletjies elletjies added the enhancement New feature or request label Dec 7, 2023
@elletjies elletjies changed the title Updated blurbs for Hebrew, Southern Sotho and Korean Updated blurbs for Hebrew, Southern Sotho, Korean and Latin Dec 12, 2023
@elletjies elletjies mentioned this pull request Dec 12, 2023
_config.yml Outdated
name: Latin
title: Glossarium
blurb: >
`glossarium` est glosarium liberum terminorum usitatorum in scientia datarum, quod
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the spelling of Glosario in the blurb be consistent across all languages as it's a proper noun?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glossarium is Glossary in Latin :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! Just that the first word is untranslated in other blurbs, i.e. glosario remains glosario, rather than a translation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see! Let me check on this tomorrow.

@froggleston
Copy link
Contributor

This looks good as far as I can tell with my zero expertise in any of the languages included in this PR! :)

@elletjies
Copy link
Member Author

@froggleston please merge if you feel comfortable with it

Copy link
Contributor

@froggleston froggleston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@elletjies elletjies merged commit c0380b0 into main Jan 9, 2024
4 checks passed
@elletjies elletjies deleted the elletjies-patch-2 branch January 9, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants