-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework definitions #253
Rework definitions #253
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/carpentries-incubator/docker-introduction/compare/md-outputs..md-outputs-PR-253 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-09-16 07:34:40 +0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@multimeric Thanks for this. I think it is a definite improvement and looks good. I'll merge it now.
Auto-generated via {sandpaper} Source : 0c0fb63 Branch : main Author : Andy Turner <[email protected]> Time : 2024-09-16 17:56:07 +0000 Message : Merge pull request #253 from WEHI-Education/rework-definitions Rework definitions
Auto-generated via {sandpaper} Source : 916103c Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-09-16 17:56:55 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 0c0fb63 Branch : main Author : Andy Turner <[email protected]> Time : 2024-09-16 17:56:07 +0000 Message : Merge pull request #253 from WEHI-Education/rework-definitions Rework definitions
Auto-generated via {sandpaper} Source : 916103c Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-09-16 17:56:55 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 0c0fb63 Branch : main Author : Andy Turner <[email protected]> Time : 2024-09-16 17:56:07 +0000 Message : Merge pull request #253 from WEHI-Education/rework-definitions Rework definitions
Auto-generated via {sandpaper} Source : 916103c Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-09-16 17:56:55 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 0c0fb63 Branch : main Author : Andy Turner <[email protected]> Time : 2024-09-16 17:56:07 +0000 Message : Merge pull request #253 from WEHI-Education/rework-definitions Rework definitions
Auto-generated via {sandpaper} Source : 916103c Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-09-16 17:56:55 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 0c0fb63 Branch : main Author : Andy Turner <[email protected]> Time : 2024-09-16 17:56:07 +0000 Message : Merge pull request #253 from WEHI-Education/rework-definitions Rework definitions
Auto-generated via {sandpaper} Source : 916103c Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2024-09-16 17:56:55 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 0c0fb63 Branch : main Author : Andy Turner <[email protected]> Time : 2024-09-16 17:56:07 +0000 Message : Merge pull request #253 from WEHI-Education/rework-definitions Rework definitions
This is a large and possibly controversial change to the introduction. I felt in particular that the "What is a Container? What is Docker?" section was too long and complicated by a few concepts that weren't strictly necessary. I've simplified it in the following ways:
Very happy to discuss this and modify it as needed.