Windows container support #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Jesse Glick <[email protected]>
Co-Authored-By: Jesse Glick <[email protected]>
Add powershell to syntax highlighting
Co-Authored-By: Jesse Glick <[email protected]>
# Conflicts: # README.md
# Conflicts: # amazoncorretto-11/mvn-entrypoint.ps1 # amazoncorretto-8/mvn-entrypoint.ps1 # jdk-11/mvn-entrypoint.ps1 # jdk-12/mvn-entrypoint.ps1 # jdk-13/mvn-entrypoint.ps1 # jdk-14/mvn-entrypoint.ps1 # jdk-8/mvn-entrypoint.ps1
# Conflicts: # .github/workflows/main.yml
|
You can see the CI run from my fork here https://github.com/slide/docker-maven/commit/a041da50ab653193ac381e8cde6f54a19ea11311/checks?check_suite_id=279990849. It was pushing to my personal repo on dockerhub. |
|
Also, here is the dockerhub repo showing the published tags. https://hub.docker.com/r/slideomix/maven/tags |
no longer available
|
thanks! |
|
I'm publishing them under https://hub.docker.com/u/csanchez/maven |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a replacement for #119. This includes the framework for building and publishing the Windows images to the maven dockerhub repo using GitHub Actions. For this to work, you would need to add secrets to this repository for DOCKER_USERNAME and DOCKER_PASSWORD.
This also takes into account the recommendation from @jglick in the previous PR to make the Windows dockerfiles self contained in one directory to reuse the .ps1 and .xml files.
I have also added nanoserver container images in this PR, something that was not available previously because some bugs in the jdk for 8 and 11.
Sorry for the many commits, I can squash into a single commit and recreate the PR if desired.