Accelerate point cloud conversion to ROS messsge #557
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I this merge request I have significantly accelerated point cloud conversion to ROS message.
I have noticed that
create_cloud
function is called with NumPy array representing points, therefore the points are already stored in a byte array in the same format as the message format.According to documentation, the
points
argument can be any list of iterables, therefore I have added the helper function_check_if_fast_byte_coversion_avaliable
, which checks if the fast path can be used in this case.Most likely the create_cloud is only called with np.ndarray for points, but I am not familiar with this codebase to ensure it.
Benchmark results:
ROS Hz results before changes:
Benchmark of carla-bridge with py-spy
ROS HZ after my modifications:
Benchamark with py-spy after modifications
This change is