-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[updated #7009] Add a *.pyi
file for auto-completion & hints.
#7787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9fe050f
to
bc1f334
Compare
Note: Since Added type hints for values attribute on enums this PR is a superset of Minokori#1 containing more changes. |
71e581e
to
f1fa9b1
Compare
3fd09a9
to
5377399
Compare
To enable auto-completion and hints in code editors such as VScode, create a `*.pyi` file. This feature is compatible with `python 3.9` and later versions.
Can be None or an Actor
needs merge with dev version
Syntax fix (squased)
FutureActor laod_world_if_different
Was changed to a function in 0.9.15. More info see: carla-simulator#7439
Functions from carla-simulator#7168
- fixed carla.Waypoint.next_until_lane_end
correctly added two overload function
Using Self will not report an override / incompatible error.
- OpendriveGenerationParameter had no init - missing @Property - wrong signatures
- wrong signatures - wrong names
parameter is called in_point not in_vector
d1f278b
to
9679a25
Compare
9679a25
to
3e82831
Compare
more setters missing, wrong types corrected spelling
4d846f0
to
49562b7
Compare
Blyron
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Daraan)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated version of the PRs #7009 + Minokori#1 from @Minokori who did the main and initial work and further corrections from me. As #7009 has not been maintained in the last months and Blyron mentioned that they might close it I choose now to make this PR as a combined and rebased version of the mentioned PRs.
Of course we should favor #7009 should it be updated and I hope everyone is fine with me opening this alternative PR, if not please close it again or leave a comment.
Setters for properties
Overloads
Overload for
get_waypoint() -> Waypoint
Is
project_to_road=True
sufficient? IncludingLaneType.NONE or Any
?Description
Fallback to
typing_extension
with version check is now added.Where has this been tested?
Possible Drawbacks
Some type checking features are only available in later Python versions (3.9+), but as this is a *.pyi stub file it depends on the IDE and not the runtime version.
This change is