Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix web assets serving strategy #4962

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix web assets serving strategy #4962

wants to merge 3 commits into from

Conversation

paolino
Copy link
Collaborator

@paolino paolino commented Jan 31, 2025 •
edited
Loading

Changes

  • Use fileEmbed to embed the web assets in the executable
  • Remove code duplication for pickMnemonics function

Issue

fix #4961

@paolino paolino added Improvement Mark a PR as an improvement, for auto-generated CHANGELOG Deposit UI UI related changes labels Jan 31, 2025
@paolino paolino self-assigned this Jan 31, 2025
abailly
abailly reviewed Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@abailly abailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than having to have several modules relying on file-embed, perhaps it would be cleaner to have one Cardano.Wallet.UI.Static module exporting CAF for each of the different files we are interested in?

@paolino paolino force-pushed the paolino/4961/fix-web-assets-serving-strategy branch from 20188bc to b70b64f Compare January 31, 2025 14:36
@paolino paolino requested a review from abailly January 31, 2025 14:37
@abailly abailly added this pull request to the merge queue Feb 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 3, 2025
@paolino paolino added this pull request to the merge queue Feb 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abailly abailly abailly approved these changes

Assignees

@paolino paolino

Labels
Deposit Improvement Mark a PR as an improvement, for auto-generated CHANGELOG UI UI related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix web UI assets location
2 participants
@paolino @abailly