Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0030 | Add register to track accepted extensions #980

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Ryun1
Copy link
Collaborator

@Ryun1 Ryun1 commented Feb 4, 2025

@Ryun1 Ryun1 marked this pull request as ready for review February 4, 2025 22:24
@Ryun1 Ryun1 requested a review from Crypto2099 February 4, 2025 22:24
@Ryun1 Ryun1 added the Category: Wallets Proposals belonging to the 'Wallets' category. label Feb 4, 2025
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to finally see this (though I thought we had more of them... I guess most are still candidates). Only potential issue is the formatting of CIP names which could be made more consistent with CIP references around Cardano literature, including other CIPs:

  1. CIP number, more often than not, is 4 digits (though people often use less when typing)
  2. a hyphen is generally used when concatenating the CIP name + title (we often use | but of course this messes up tables)... alternatively this could be split into 2 columns.

Comment on lines +9 to +12
| CIP-95 Web-Wallet Bridge - Conway ledger era | https://github.com/cardano-foundation/CIPs/tree/master/CIP-0095 | Extension to enable support for Conway ledger era and governance |
| CIP-103 Web-Wallet Bridge - Bulk transaction signing | https://github.com/cardano-foundation/CIPs/tree/master/CIP-0103 | Extension to provide an additional endpoint for dApp to sign multiple transactions in bulk |
| CIP-104 Web-Wallet Bridge - Account public key | https://github.com/cardano-foundation/CIPs/tree/master/CIP-0104 | Extension to provide an additional endpoint for dApp to get the extended account public key from a connected wallet |
| CIP-106 Web-Wallet Bridge - Multisig wallets | https://github.com/cardano-foundation/CIPs/tree/master/CIP-0106 | Extension to provide a interface for dApps and Cardano Multisig-wallets |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| CIP-95 Web-Wallet Bridge - Conway ledger era | https://github.com/cardano-foundation/CIPs/tree/master/CIP-0095 | Extension to enable support for Conway ledger era and governance |
| CIP-103 Web-Wallet Bridge - Bulk transaction signing | https://github.com/cardano-foundation/CIPs/tree/master/CIP-0103 | Extension to provide an additional endpoint for dApp to sign multiple transactions in bulk |
| CIP-104 Web-Wallet Bridge - Account public key | https://github.com/cardano-foundation/CIPs/tree/master/CIP-0104 | Extension to provide an additional endpoint for dApp to get the extended account public key from a connected wallet |
| CIP-106 Web-Wallet Bridge - Multisig wallets | https://github.com/cardano-foundation/CIPs/tree/master/CIP-0106 | Extension to provide a interface for dApps and Cardano Multisig-wallets |
| CIP-0095 - Web-Wallet Bridge - Conway ledger era | https://github.com/cardano-foundation/CIPs/tree/master/CIP-0095 | Extension to enable support for Conway ledger era and governance |
| CIP-0103 - Web-Wallet Bridge - Bulk transaction signing | https://github.com/cardano-foundation/CIPs/tree/master/CIP-0103 | Extension to provide an additional endpoint for dApp to sign multiple transactions in bulk |
| CIP-0104 - Web-Wallet Bridge - Account public key | https://github.com/cardano-foundation/CIPs/tree/master/CIP-0104 | Extension to provide an additional endpoint for dApp to get the extended account public key from a connected wallet |
| CIP-0106 - Web-Wallet Bridge - Multisig wallets | https://github.com/cardano-foundation/CIPs/tree/master/CIP-0106 | Extension to provide a interface for dApps and Cardano Multisig-wallets |

@rphair rphair changed the title CIP-30 | Add register to track accepted extensions CIP-0030 | Add register to track accepted extensions Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Wallets Proposals belonging to the 'Wallets' category.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants