Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0116 | Add Conway JSON schema #912

Merged
merged 20 commits into from
Jan 7, 2025

Conversation

klntsky
Copy link
Contributor

@klntsky klntsky commented Sep 16, 2024

List of changes in this PR (from #912 (comment)):

  • Add Conway era schema
  • Add required fields to UnitInterval
  • Add required fields to plutusData variants
  • Replace additionalProperties with unevaluatedProperties
    • See this issue for more details. In summary: schemas with unevaluatedProperties are easier to compose.
  • Add examples for some types
    • Useful when generating values from these schemas

The corresponding tests are located at https://github.com/mlabs-haskell/cip-0116-tests

@klntsky klntsky marked this pull request as draft September 16, 2024 19:47
@rphair rphair added Update Adds content or significantly reworks an existing proposal Category: Tools Proposals belonging to the 'Tools' category. labels Oct 7, 2024
@klntsky klntsky marked this pull request as ready for review November 7, 2024 16:40
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing in response to ping from @nazrhom in #869 (comment) - I think I had expected @Ryun1 to yea or nea this one and then I think it fell through the cracks past all of us 😬 ... tagging Last Check to ensure it doesn't evade us past the next CIP meeting (07 January), but also polling other editors for hopefully a review & merge before then.

@rphair rphair added the State: Last Check Review favourable with disputes resolved; staged for merging. label Dec 13, 2024
@nazrhom
Copy link
Contributor

nazrhom commented Dec 17, 2024

Thanks @rphair

I can't edit the original comment, but here is a list of changes in this PR:

  • Add Conway era schema
  • Add required fields to UnitInterval
  • Add required fields to plutusData variants
  • Replace additionalProperties with unevaluatedProperties
    • See this issue for more details. In summary: schemas with unevaluatedProperties are easier to compose.
  • Add examples for some types
    • Useful when generating values from these schemas

@rphair rphair changed the title CIP-0116: add Conway json schema CIP-0116 | Add Conway JSON schema Dec 17, 2024
@rphair rphair requested a review from Ryun1 January 6, 2025 09:22
CIP-0116/cardano-conway.json Outdated Show resolved Hide resolved
@rphair rphair merged commit 8fa5e3b into cardano-foundation:master Jan 7, 2025
@rphair rphair removed the State: Last Check Review favourable with disputes resolved; staged for merging. label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Tools Proposals belonging to the 'Tools' category. Update Adds content or significantly reworks an existing proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants