Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added info on symbolic tokens in design docs #2657

Merged

Conversation

aswin2108
Copy link
Contributor

The Operators proposal #601 got accepted and but the details were not updated in the design docs. Added symbolic_tokens.md file to add the details of the proposal and its discussion.

Closes #1992

@github-actions github-actions bot requested a review from josh11b March 5, 2023 12:21
@aswin2108
Copy link
Contributor Author

@geoffromer As you said I will make the table into one row to be more concise. But the problem is I am confused about which doc I should refer to update the list. The explorer's lexer list or toolchain's lexer definition or any other??

@geoffromer
Copy link
Contributor

@aswin2108 I think we should update the list based on the other documents in docs/design, not based on the explorer or toolchain code. I linked to the ones I know of in my comment here

@aswin2108 aswin2108 requested a review from geoffromer April 29, 2023 08:12
@aswin2108 aswin2108 requested a review from geoffromer May 16, 2023 17:07
@geoffromer
Copy link
Contributor

This looks good to me. Ideally I'd prefer for this comment to be addressed, but that's a minor issue.

I'm leaving approval to @josh11b since he had requested changes.

@aswin2108
Copy link
Contributor Author

@geoffromer I didn't understand that actually! From my understanding I made the previous version of the table, but at that time you said some separators were missing so I thought you wanted it this way! Can you give me an example? I will update it.

@geoffromer
Copy link
Contributor

This looks good to me.

@josh11b josh11b merged commit 6d399c8 into carbon-language:trunk Jun 2, 2023
josh11b added a commit to josh11b/carbon-lang that referenced this pull request Jun 2, 2023
zygoloid pushed a commit that referenced this pull request Jun 2, 2023
With this change `docs/design/lexical_conventions/symbolic_tokens.md` should now include all operators and symbols from accepted proposals.
@aswin2108 aswin2108 deleted the Add-symbolic-tokens-in-design-docs branch June 3, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reflect "Operator tokens #601" in the design docs
5 participants