-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added info on symbolic tokens in design docs #2657
Added info on symbolic tokens in design docs #2657
Conversation
@geoffromer As you said I will make the table into one row to be more concise. But the problem is I am confused about which doc I should refer to update the list. The explorer's lexer list or toolchain's lexer definition or any other?? |
@aswin2108 I think we should update the list based on the other documents in |
This looks good to me. Ideally I'd prefer for this comment to be addressed, but that's a minor issue. I'm leaving approval to @josh11b since he had requested changes. |
@geoffromer I didn't understand that actually! From my understanding I made the previous version of the table, but at that time you said some separators were missing so I thought you wanted it this way! Can you give me an example? I will update it. |
This looks good to me. |
With this change `docs/design/lexical_conventions/symbolic_tokens.md` should now include all operators and symbols from accepted proposals.
The Operators proposal #601 got accepted and but the details were not updated in the design docs. Added
symbolic_tokens.md
file to add the details of the proposal and its discussion.Closes #1992