Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [1623] Add missing scrollBy functionality #1624

Conversation

OlaviSau
Copy link
Contributor

Just filling in the method :)

@OlaviSau
Copy link
Contributor Author

@capricorn86 should hopefully be a simple one. LMK if you want improvements :)

@OlaviSau OlaviSau force-pushed the feature-1623-add-missing-scroll-by-feature branch from 467f999 to 108467d Compare December 4, 2024 12:52
capricorn86
capricorn86 previously approved these changes Dec 30, 2024
Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @OlaviSau! ⭐

Sorry that it took some time to get this in.

I have added some unit tests and also found that "x" and "y" where reversed when not providing an object as argument.

Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also noticed that scrollBy() was missing on Window as well, so I've also added it there now

@capricorn86 capricorn86 merged commit 5629a74 into capricorn86:master Dec 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants