fix: Allow getElementsByClassName to accept a whitespace-separated list #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be a solution for #1551 |
…sName space separated list
capricorn86
approved these changes
Dec 30, 2024
There was a problem hiding this comment.
Thank you for your contribution @kylehalleman! 🌟
Sorry that it took such a long time to get this in.
I have changed the solution a bit to improve performance by only using a replace().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getElementsByClassNamecan accept a whitespace-separated list of classNames (see MDN and spec).The current implementation prepends
.to the className inquerySelectorAll(i.e.,classOne classTwo classThree->.classOne classTwo classThree). This PR splits the className string by any amount of whitespace, then prepends a.to each separated className, then joins to make a single query toquerySelectorAll(e.g.,classOne classTwo classThree->.classOne.classTwo.classThree).Added test to confirm this new functionality.