-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/respect ruby version file #60
base: master
Are you sure you want to change the base?
Conversation
on primary(:app) do | ||
within release_path do | ||
ruby_version = capture(:rvm, "current") | ||
# FIX ME: when calling `set :rvm_ruby_version, ruby_version` here directly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anybody has an idea on how to improve on this here? Thanks 👍
I made some changes in the meanwhile:
|
When this will be merged? |
/cc @kirs |
Looks nice, but I'd avoid calling |
What is left here? |
👍 would be great to have this merged in. At the present, it is very cumbersome to upgrade ruby versions. |
Any updates on this? |
FWIW, today As I mentioned in #59, I found that just using this works nicely: set :rvm_ruby_version, IO.read('.ruby-version') |
I have new line on the end of the string, which is prevents from deployment. |
cap staging rvm:check
now always outputs something, not only whenlog_level
is set todebug
. It's now only automatically invoked on normal deploying if thelog_level
isdebug
, so no change in behavior here.cap staging rvm:check
is now executed in the current release path, so RVM will pickup any.ruby-version
file and only fall back to the system defaults.rvm_ruby_version
is no longer set todefault
. Instead the ruby version reported bycap staging rvm:check
is used by default now.