rm cds._telemetry

cap-js · Jan 7, 2025 · 27cec3b · 27cec3b
1 parent 50e405e
commit 27cec3b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -3,7 +3,7 @@ const LOG = cds.log('telemetry')
 
 const { diag } = require('@opentelemetry/api')
 const { registerInstrumentations } = require('@opentelemetry/instrumentation')
-const { ATTR_SERVICE_NAME, ATTR_SERVICE_VERSION } = require('@opentelemetry/semantic-conventions')
+// const { ATTR_SERVICE_NAME, ATTR_SERVICE_VERSION } = require('@opentelemetry/semantic-conventions')
 
 const tracing = require('./tracing')
 const metrics = require('./metrics')
@@ -47,11 +47,11 @@ module.exports = function () {
 
   const resource = getResource()
 
-  // REVISIT: better way to make available?
-  cds._telemetry = {
-    name: resource.attributes[ATTR_SERVICE_NAME],
-    version: resource.attributes[ATTR_SERVICE_VERSION]
-  }
+  // // REVISIT: better way to make available?
+  // cds._telemetry = {
+  //   name: resource.attributes[ATTR_SERVICE_NAME],
+  //   version: resource.attributes[ATTR_SERVICE_VERSION]
+  // }
 
   /*
    * setup tracing

diff --git a/lib/tracing/index.js b/lib/tracing/index.js
@@ -158,13 +158,13 @@ module.exports = resource => {
     tracerProvider.addSpanProcessor(spanProcessor)
   }
 
-  // REVISIT: better way to set/ pass tracer?
-  cds._telemetry.tracer = trace.getTracer('@cap-js/telemetry', require('../../package.json').version)
+  // // REVISIT: better way to set/ pass tracer?
+  // cds._telemetry.tracer = trace.getTracer('@cap-js/telemetry', require('../../package.json').version)
 
-  // REVISIT: only start tracing once served
-  cds.on('served', () => {
-    cds._telemetry.tracer._active = true
-  })
+  // // REVISIT: only start tracing once served
+  // cds.on('served', () => {
+  //   cds._telemetry.tracer._active = true
+  // })
 
   // clear sap passport for new tx
   if (process.env.SAP_PASSPORT) {