Merge pull request #77 from cap-js/Issue-73-appcrash

Issue 73:App crash
cap-js · Oct 28, 2024 · 87c84e8 · 87c84e8
2 parents c3ea69a + d55a480
commit 87c84e8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/index.cds b/index.cds
@@ -1,6 +1,6 @@
 using { Attachments} from '@cap-js/attachments';
 extend aspect Attachments with {
-    folderId : String @title: 'Folder ID';
+    folderId : String @title: 'Folder ID' @readonly;
 };
 
 annotate Attachments with @UI:{
@@ -16,6 +16,7 @@ annotate Attachments with @UI:{
     {Value: note}
   ]
 } {
+  url @readonly;
   content
     @Core.ContentDisposition: { Filename: filename }
     @Core.Immutable

diff --git a/lib/sdm.js b/lib/sdm.js
@@ -211,6 +211,7 @@ async isFileNameDuplicateInDrafts(data,req) {
     if (attachments) {
       const diffData = await req.diff();
       let deletedAttachments = [];
+      if(diffData.attachments){
       diffData.attachments
         .filter((object) => {
           return object._op === "delete";
@@ -243,6 +244,7 @@ async isFileNameDuplicateInDrafts(data,req) {
         }
       }
     }
+    }
   }
 
   async deleteAttachmentsWithKeys(records, req) {