Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: name clashes with CDS elements named nodes and totalCount #137

Merged
merged 30 commits into from
Nov 23, 2023
Merged

fix: name clashes with CDS elements named nodes and totalCount #137

merged 30 commits into from
Nov 23, 2023

Conversation

schwma
Copy link
Member

@schwma schwma commented Nov 21, 2023

No description provided.

schwma added 29 commits January 16, 2023 15:57
@schwma
Add test querying only totalCount
06ca29b
@schwma
Check if is connection from selected field names
8bbd168
@schwma
Add changelog entry
0cdfbec
@schwma
Merge branch 'main' into fix-totalCount-without-nodes
6154b69
@schwma
Use gql tag in test
7a1675d
@schwma
Use ternary conditional operator
e8efc2b
@schwma
Merge branch 'main' into fix-totalCount-without-nodes
186f9c6
@schwma
Fix CDS name with nodes and totalCount
65c0963
@schwma
Add changelog entry
73f7c86
@schwma
Test to reproduce name clashes
150ef92
@schwma
Merge branch 'main' into name-clashes-with-nodes-and-totalCount
6fc1375
@schwma
Merge branch 'main' into name-clashes-with-nodes-and-totalCount
d4816f9
@schwma
Merge branch 'main' into name-clashes-with-nodes-and-totalCount
6f57653
@schwma
Regenerate schemas
5edbe82
@schwma
Remove duplicate changelog entry
dea2390
@schwma
Move resultInArray into formatResult
792e1a0
@schwma
Merge branch 'main' into name-clashes-with-nodes-and-totalCount
053c2b3
@schwma
Annotate edge case services with @graphql
ba0302d
@schwma
Regenerate schemas
548e8c6
@schwma
Reorder entity definitions
c48c6ce
@schwma
Remove unused managed import
8e99f67
@schwma
Replace config in server.js with package.json
9395a3a
@schwma
Remove unused imports
188eae4
@schwma
Fix argument name
bd6f008
@schwma
Reorder entity definitions
e30b704
@schwma
Replace data.autoReset() with data.reset()
0456d60
@schwma
Extract element type to variable
cccb665
@schwma
Add TODO to not wrap singletons in arrays
7b1074f
@schwma
Merge branch 'main' into name-clashes-with-nodes-and-totalCount
90f9d14
@schwma schwma requested a review from a team as a code owner November 21, 2023 14:15
sjvans
sjvans approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@sjvans sjvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@schwma schwma merged commit e5ac50b into main Nov 23, 2023
3 checks passed
@schwma schwma deleted the name-clashes-with-nodes-and-totalCount branch November 23, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjvans sjvans sjvans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schwma @sjvans