Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: consume org workflows #397

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

ci: consume org workflows #397

wants to merge 7 commits into from

Conversation

joergmann
Copy link
Contributor

@joergmann joergmann commented Jan 23, 2025

First Draft

Open issues

  • adapt changelog to unreleased format
  • use next version workflow
  • lint check renaming
  • test.yml executed rollup:off and rollup:on tests, whereas release.yml executed only rollup:on tests -> on purpose?

@joergmann joergmann self-assigned this Jan 23, 2025
@joergmann joergmann marked this pull request as draft January 23, 2025 14:51
@joergmann joergmann requested a review from daogrady January 23, 2025 15:09
@daogrady
Copy link
Contributor

test.yml executed rollup:off and rollup:on tests, whereas release.yml executed only rollup:on tests -> on purpose?

Yes, we test the types both in bundled, as well as in unbundled state. The former will be released, the latter is what we see during development. So both should work properly.
When we release, we only want the bundled version, so there we only have rollup:on

@joergmann joergmann marked this pull request as ready for review January 24, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants