Make @types/express a peerDependency
#380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chgeo
approved these changes
Dec 12, 2024
hakimio
reviewed
Dec 13, 2024
| "dependencies": { | ||
| "@types/express": "^4.17.21" | ||
| "@sap/cds": "^8.0.0", | ||
| "@types/express": ">=5" |
There was a problem hiding this comment.
@daogrady
Just curious: why did you change >=4 to >=5? Now the changelog entry is not correct too.
There was a problem hiding this comment.
You're right, that's obviously incorrect, thanks for pointing it out!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #375
This allows users to freely choose between
@types/expressv4 and v5. This is in line with how we handle things in@sap/cds. I have verified that all uses of theexpresspackage within our type declarations work in v5 as well.Starting (again) with npm7, peerDependencies are automatically installed if they are not resolvable otherwise, so this should not effect our JS users who have no explicit dependency on
@types/express.