postinstall script: support monorepos
#191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This happens in monorepo setups where `cds-types` is alreday installed.
chgeo
force-pushed
the
install-monorepos
branch
2 times, most recently
from
b53e613 to
a325593
Compare
chgeo
force-pushed
the
install-monorepos
branch
from
a325593 to
44750e5
Compare
|
@joergmann my new monorepo test fails on Windows with Can you make any sense out of it? Does the test run for you locally? |
chgeo
changed the title
postinstall script finds existing cds-types installationpostinstall script
chgeo
changed the title
postinstall scriptpostinstall script: support monorepos
|
@joergmann please make sure to have the latest non 10.8.2 installed. |
|
@chgeo fixed, will revistit to make it more robust |
joergmann
approved these changes
Aug 13, 2024
|
@daogrady this is the PR by Joerg and me, targeting the next cds-types patch. |
daogrady
reviewed
Aug 13, 2024
daogrady
reviewed
Aug 13, 2024
| name: 'project1' | ||
| }, null, 2)) | ||
| { | ||
| // const {stdout, stderr} = |
There was a problem hiding this comment.
Suggested change
| // const {stdout, stderr} = |
daogrady
reviewed
Aug 13, 2024
| { | ||
| // const {stdout, stderr} = | ||
| await execAsync(`npm i --foreground-scripts -dd -D ${cdsTypesRoot}`, { cwd: project1 }) | ||
| // console.log(stdout, stderr) |
There was a problem hiding this comment.
Suggested change
| // console.log(stdout, stderr) |
daogrady
reviewed
Aug 13, 2024
| } | ||
| }, null, 2)) | ||
| { | ||
| // const {stdout, stderr} = |
There was a problem hiding this comment.
Suggested change
| // const {stdout, stderr} = |
daogrady
reviewed
Aug 13, 2024
| { | ||
| // const {stdout, stderr} = | ||
| await execAsync(`npm i --foreground-scripts -dd`, { cwd: project2 }) | ||
| // console.log(stdout, stderr) |
There was a problem hiding this comment.
Suggested change
| // console.log(stdout, stderr) |
daogrady
reviewed
Aug 13, 2024
| @@ -16,6 +16,7 @@ describe('postinstall', () => { | |||
|
|
|||
| beforeEach(async () => { | |||
| tempFolder = await fs.mkdtemp(path.join(os.tmpdir(), 'postinstall-')) | |||
| // console.log(`tempFolder: ${tempFolder}`) | |||
There was a problem hiding this comment.
Suggested change
| // console.log(`tempFolder: ${tempFolder}`) |
daogrady
reviewed
Aug 13, 2024
|
Very valuable contribution, thank you both! I only added some minor nits, but I think this is good to go. |
daogrady
approved these changes
Aug 13, 2024
Co-authored-by: Daniel O'Grady <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In monorepo setups
cds-typesmight already be installed elsewhere (higher up), so find and use it as link target.