fix: starts endswith for null values #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larslutz96
changed the title
larslutz96
requested review from
danjoa,
johannes-vogel,
stewsk,
BobdenOs,
patricebender,
sjvans and
David-Kunz
as code owners
larslutz96
changed the title
| @@ -75,15 +75,15 @@ const StandardFunctions = { | |||
| * @param {string} y | |||
| * @returns {string} | |||
| */ | |||
| startswith: (x, y) => `instr(${x},${y}) = 1`, // sqlite instr is 1 indexed | |||
| startswith: (x, y) => `coalesce(instr(${x},${y}) = 1,false)`, // sqlite instr is 1 indexed | |||
There was a problem hiding this comment.
this covers only SQLite, is this also relevant for other dbs?:)
There was a problem hiding this comment.
added same for postgres. Not relevant for hana
larslutz96
requested review from
gregorwolf,
sebastianesch and
vobu
as code owners
patricebender
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap
startswithandendswithwithcoalesceto return false when element isNULL.