Use integrity Field from yarn.lock as sha512 for Nix Derivation #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pathway27
changed the title
pathway27
commented
Dec 19, 2022
| @@ -1,6 +1,6 @@ | |||
| // @ts-check | |||
|
|
|||
| const lockfile = require('@yarnpkg/lockfile'); | |||
There was a problem hiding this comment.
This upstream package doesn't have it defined in the type though... 😞
pathway27
commented
Dec 19, 2022
| export interface FirstLevelDependency { | ||
| version: string; | ||
| resolved?: string | undefined; | ||
| integrity?: string | undefined; |
There was a problem hiding this comment.
Only extra line compared to @yarnpkg/lockfile
|
Hey @pathway27, thanks for raising this issue, this is true, we can leverage this field from the modern-built lockfiles. The build seems failing, would you mind to fix it before the review? Thanks! |
andrew-vts
added a commit
to viewthespace/js2nix
that referenced
this pull request
Feb 23, 2023
andrew-vts
added a commit
to viewthespace/js2nix
that referenced
this pull request
Feb 23, 2023
andrew-vts
added a commit
to viewthespace/js2nix
that referenced
this pull request
Feb 23, 2023
andrew-vts
added a commit
to viewthespace/js2nix
that referenced
this pull request
Feb 23, 2023
andrew-vts
added a commit
to viewthespace/js2nix
that referenced
this pull request
Feb 24, 2023
andrew-vts
added a commit
to viewthespace/js2nix
that referenced
this pull request
Feb 24, 2023
andrew-vts
added a commit
to viewthespace/js2nix
that referenced
this pull request
Feb 24, 2023
andrew-vts
added a commit
to viewthespace/js2nix
that referenced
this pull request
Feb 24, 2023
andrew-vts
added a commit
to viewthespace/js2nix
that referenced
this pull request
Feb 24, 2023
andrew-vts
added a commit
to viewthespace/js2nix
that referenced
this pull request
Feb 24, 2023
andrew-vts
added a commit
to viewthespace/js2nix
that referenced
this pull request
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newset yarn version (1.22.19) generates yarn.lock files which don't have the sha1 in their url with a
#, so fails for some users.One public example I've found: https://github.com/iptv-org/iptv/blob/master/yarn.lock#L7.
But I notice most lockfiles have an
integrityfield. See https://github.com/canva-public/js2nix/blob/main/yarn.lock#L8