-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate to starflow #5225
Open
bepri
wants to merge
29
commits into
main
Choose a base branch
from
work/starflow-migration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
f705806
style: fix ruff warning
bepri 2c5b2d8
docs: convert README to rst
bepri 7dc2957
build: migrate to pyproject for building with uv
bepri 97b579a
chore: replace black with ruff formatter
bepri 438ef37
build: bring in starbase makefile
bepri 9574400
chore: move data_files and scripts from setup.py into pyproject.toml
bepri 29805f5
build: remove all requirements files and generate requirements with uv
bepri 1b7252a
chore: migrate last of setup.py
bepri da560c8
chore: remove unused tools
bepri 4afe5dc
build: delete tox.ini
bepri a2f3bda
chore: organize gitignore
bepri 86b36ff
style: bring in starbase formatter rules
bepri 8abde29
test: mark slow tests
bepri 02a35a5
chore: remove outdated/unused top-level files
bepri a99ccc0
docs: delete now-obsolete TESTING.md
bepri f81f681
docs: update HACKING.md with new environment information
bepri 2d8a4c1
build: add python-apt wheels
bepri dd8aee6
ci: update workflow files for starflow/uv
bepri d79164e
style: add pre-commit config
bepri 1a4c27e
ci(docs): update readthedocs config to use uv
bepri e7f4864
chore: correct all typing errors
bepri ab86c40
style: run prettier
bepri b687ad4
ci: configure starflow test run
bepri 9a6c73e
chore: fix shellcheck warning on kde neon extension
bepri b45182f
chore: move docutils into docs dependency group
bepri 7b22826
chore: pin craft-application for test failures
bepri 7a25bf8
fix(docs): properly ignore lines being too long for now
bepri a5e9cd8
test(spread): remove nonexistent files from spread.yaml
bepri 4df5913
ci: make trivy ignore things we don't need to scan
bepri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -62,4 +62,3 @@ body: | |
id: additional-context | ||
attributes: | ||
label: Additional context | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
- [ ] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? | ||
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? | ||
- [ ] Have you successfully run `tox run -m lint`? | ||
- [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) | ||
- [ ] Have you successfully run `make lint`? | ||
- [ ] Have you successfully run `make test`? | ||
|
||
----- | ||
--- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,14 @@ | ||
{ | ||
"problemMatcher": [ | ||
"problemMatcher": [ | ||
{ | ||
"owner": "spread-error", | ||
"pattern": [ | ||
{ | ||
"owner": "spread-error", | ||
"pattern": [ | ||
{ | ||
"regexp": "^\\d+-\\d+-\\d+ \\d+:\\d+:\\d+ ((Error) (preparing|executing|restoring) .+) : .*$", | ||
"message": 1, | ||
"severity": 2 | ||
} | ||
] | ||
"regexp": "^\\d+-\\d+-\\d+ \\d+:\\d+:\\d+ ((Error) (preparing|executing|restoring) .+) : .*$", | ||
"message": 1, | ||
"severity": 2 | ||
} | ||
] | ||
] | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
name: Check policy | ||
on: | ||
pull_request: | ||
push: | ||
branches: | ||
- main | ||
- hotfix/* | ||
- work/check-policy # For development | ||
|
||
jobs: | ||
policy: | ||
uses: canonical/starflow/.github/workflows/policy.yaml@main | ||
python-scans: | ||
name: Security scan | ||
uses: canonical/starflow/.github/workflows/scan-python.yaml@main | ||
with: | ||
# 1. requirements-noble.txt can't build on jammy | ||
# 2. Ignore requirements files in spread tests, as some of these intentionally | ||
# contain vulnerable versions. | ||
# 3. Docs contain requirements.txt files that don't specify versions. | ||
requirements-find-args: '! -name requirements-noble.txt ! -path "./tests/spread*" ! -path "./docs/**"' | ||
trivy-extra-args: "--severity HIGH,CRITICAL --ignore-unfixed --skip-dirs tests/spread/" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
name: CI | ||
|
||
on: | ||
on: | ||
pull_request: | ||
push: | ||
branches: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
name: QA | ||
on: | ||
push: | ||
branches: | ||
- "main" | ||
- "feature/*" | ||
- "hotfix/*" | ||
- "release/*" | ||
- "renovate/*" | ||
pull_request: | ||
|
||
jobs: | ||
lint: | ||
uses: canonical/starflow/.github/workflows/lint-python.yaml@main | ||
test: | ||
uses: canonical/starflow/.github/workflows/test-python.yaml@main | ||
with: | ||
# Snapcraft currently only tests on Python 3.12 on Ubuntu 24.04 | ||
fast-test-platforms: '["ubuntu-24.04"]' | ||
slow-test-platforms: '["ubuntu-24.04"]' | ||
lowest-python-platform: "ubuntu-24.04" | ||
fast-test-python-versions: '["3.12"]' | ||
slow-test-python-versions: '["3.12"]' | ||
lowest-python-version: "3.12" |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sergiusens should we be using self-hosted runners for this or GH-hosted ones?