docs: migrate kde neon extensions #5220
Open
+643
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a placeholder commit. Will be squashed when other extension work is merged.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5220 +/- ##
==========================================
- Coverage 94.88% 89.68% -5.21%
==========================================
Files 658 342 -316
Lines 55189 22636 -32553
==========================================
- Hits 52364 20300 -32064
+ Misses 2825 2336 -489 ☔ View full report in Codecov by Sentry. |
lengau
reviewed
Jan 28, 2025
|
Will be reorienting around KDE 6 before opening for full review. |
medubelko
changed the title
jahn-junior
approved these changes
Jan 29, 2025
| Runtime environment | ||
| ~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| The KDE neon extensions also sets various runtime environment variables for apps. |
There was a problem hiding this comment.
Suggested change
| The KDE neon extensions also sets various runtime environment variables for apps. | |
| The KDE neon extensions also set various runtime environment variables for apps. |
| Included layouts | ||
| ---------------- | ||
|
|
||
| The KDE neon 6 extension adds the following `layout |
There was a problem hiding this comment.
Suggested change
| The KDE neon 6 extension adds the following `layout | |
| The KDE neon 6 extension adds the following `layouts |
|
|
||
| Here's an example of the result of Snapcraft expanding project files that use the KDE | ||
| neon 5 and 6 extensions, immediately prior to build. It demonstrates the added plugs, | ||
| packages, variables, and layouts, that the extensions include in projects. |
There was a problem hiding this comment.
Suggested change
| packages, variables, and layouts, that the extensions include in projects. | |
| packages, variables, and layouts that the extensions include in projects. |
lengau
reviewed
Jan 30, 2025
| kcalc: | ||
| command: usr/bin/kcalc | ||
| extensions: | ||
| - kde-neon |
There was a problem hiding this comment.
IDK whether this is relevant but we probably should use the neon 6 extension here if this file gets merged.
lengau
reviewed
Jan 30, 2025
| <https://snapcraft.io/kf5-5-113-qt-5-15-11-core22-sdk>`_ | ||
|
|
||
| The extensions are designed for C++ based Qt/KDE Frameworks apps. They don't provide the | ||
| bindings needed in PySide2 (Qt for Python) or PyQt apps. The extensions also don't |
There was a problem hiding this comment.
Suggested change
| bindings needed in PySide2 (Qt for Python) or PyQt apps. The extensions also don't | |
| bindings needed for PySide2 (Qt for Python) or PyQt apps. The extensions also don't |
lengau
reviewed
Jan 30, 2025
Comment on lines
+148
to
+151
| For an example of a part's ``build-environment`` section modified by the KDE neon 6 | ||
| extension, it sets the ``PATH``, ``XDG_DATA_DIRS``, and ``SNAPCRAFT_CMAKE_ARGS`` | ||
| environment variables during build. These defaults can be overridden by being | ||
| pre-emptively declared in the project file. |
There was a problem hiding this comment.
These sentences sound a bit awkward
lengau
reviewed
Jan 30, 2025
| .. literalinclude:: ../code/extensions/kde-neon-extension-kcalc-expanded.diff | ||
| :language: diff | ||
| :lines: 3- | ||
| :emphasize-lines: 15-19, 27-28, 64-103 |
There was a problem hiding this comment.
Suggested change
| :emphasize-lines: 15-19, 27-28, 64-103 | |
| :emphasize-lines: 15-19, 27-28, 58-103 |
lengau
reviewed
Jan 30, 2025
| .. group-tab:: KDE neon 6 | ||
|
|
||
| The original is a `project file | ||
| <https://invent.kde.org/alexlowe/keysmith/-/blob/aml/snapcraft/snapcraft.yaml>`_ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox run -m lint?tox run -e test-py310? (supported versions:py39,py310,py311,py312)For review, please focus on
docs/reference/extensions/kde-neon-extensions.rst. The other files will be merged through another PR.