-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add details about real-time on interim releases of Ubuntu (#62) #85
base: main
Are you sure you want to change the base?
Conversation
9802996
to
748f9bf
Compare
@AnneCYH Do you know why the main documentation check is failing? I can access the URL it says it can't access. Should I keep retrying until it works? Edit: It took 3 tries, but it worked! ¯_(ツ)_/¯ |
748f9bf
to
c6465ed
Compare
Given the changes coming to the realtime kernel on Ubuntu Core, I'm removing the mention of the 6.11 kernel on Ubuntu Core for now. We can add that info later once we've decided on the plan. |
The ubuntu-realtime package for oracular is queued for release. Once released, I'll mark this PR ready for review. |
Hey @khbecker , the URL checks are a little unstable but we haven't found out why exactly this is. We introduced a PR recently in the documentation starter pack template to increase the retries to 3 times (seems to be same as your magic number!). I'll add the same to our repo. |
Signed-off-by: Kevin Becker <[email protected]>
c6465ed
to
818a0c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks.
I have a suggestion about the examples in the title.
LTS releases of Ubuntu (e.g. 22.04, 24.04) | ||
------------------------------------------ | ||
|
||
Refer to `Ubuntu Pro Client - How to enable Real-time Ubuntu`_ to set up a | ||
supported Ubuntu machine. | ||
|
||
.. _Ubuntu Pro Client - How to enable Real-time Ubuntu: https://canonical-ubuntu-pro-client.readthedocs-hosted.com/en/latest/howtoguides/enable_realtime_kernel/ No newline at end of file | ||
.. _Ubuntu Pro Client - How to enable Real-time Ubuntu: https://canonical-ubuntu-pro-client.readthedocs-hosted.com/en/latest/howtoguides/enable_realtime_kernel/ | ||
|
||
Interim releases of Ubuntu (e.g. 24.10, 25.04) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure adding headers to a re-usable text is the best idea because it makes assumptions about the caller's hierarchical structure. What do you think @AnneCYH?
Currently, it turns out okay:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense. I think it works in this case, but I can see how it could become a problem. @AnneCYH, I'm fine with whatever the best practices are here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the intent is to keep the headings consistent, then I would use different markers to include the header for different levels. But it'll be a lot cleaner with Markdown compared to rST just because of the syntax.
For example, in the reuse file:
start-level-2
## Level 2 heading starts here
end-level-2
start-level-3
### Level 2 heading starts here
end-level-3
And in the source file referencing it, for a level 2 heading:
```{include} /reuse/myst-install.txt
:start-after: start-level-2
:end-before: end-level-2
```
I know it's not exactly a reuse but it keeps everything in one place for easy maintenance.
Otherwise it would be better to just exclude it from the reuse file.
In this case I would leave the headings in the reuse file since (as you both mentioned) it works for now. But I would leave a note to indicate that the heading levels need to be taken into account when reusing this file.
So for example in install-rtu.txt
, i would a line to this effect:
.. NOTE: heading levels must be taken into account when including this file
LTS releases of Ubuntu (e.g. 22.04, 24.04)
------------------------------------------
[...]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I agree about removing the releases from the headings.
- I would like to the releases.rst file as suggested by @farshidtz and also link to https://ubuntu.com/about/release-cycle for "more information" for users who may not be aware what an LTS vs interim release is.
No description provided.